Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync feature/atree-register-inlining branch with master branch #2848

Merged
merged 206 commits into from
Oct 5, 2023
Merged

Sync feature/atree-register-inlining branch with master branch #2848

merged 206 commits into from
Oct 5, 2023

Conversation

fxamacker
Copy link
Member

Updates #2809 onflow/atree#292

Description

Sync feature/atree-register-inlining branch with latest master branch.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent and others added 30 commits June 29, 2023 10:36
@turbolent
improve end pos of argument label: include colon
acb1e61
@turbolent
move support for suggested fixes to sema
6f71d49
@turbolent
add suggested fixes for missing argument label error and incorrect ar…
f681b3d 
…gument label error
@turbolent
Merge branch 'master' into bastian/improve-argument-labels
31f7035
@turbolent
suggest optional chaining
dc80acb
@turbolent @SupunS
add support for max parameter count
7f0f7e6
@turbolent @SupunS
Update runtime/sema/type.go
4a8ffd9
@turbolent @SupunS
lint
76ff4d3
@turbolent @SupunS
fix merge
46cc113
@turbolent @SupunS
fix resource loss check
123ef2c
@turbolent @SupunS
fix checking of reference expressions involving optionals
1a5b751
@turbolent @SupunS
do not repeatedly report type mismatch errors
74e4557
@turbolent @SupunS
test should fail
c8d793a
@turbolent @SupunS
fix reference expression borrow type
9a3aa84
@turbolent @SupunS
adjust tests
90418ca
@turbolent @dsainati1 @SupunS
simplify boolean expression
5719f00 
Co-authored-by: Daniel Sainati <[email protected]>
@turbolent @SupunS
do not unwrap referenced optional anymore
ea8981f
@SupunS
Add runtime tracking for reference to optional resource
ef71256
@turbolent @SupunS
add reproducer for stack overflow issue
bb98151
@turbolent @SupunS
prevent recursion in transfers
458f734
@turbolent @SupunS
prevent transfer of insertion target
bb4c1eb
@turbolent @SupunS
make resursive transfer error a user error, improve test name
5246348
@turbolent @SupunS
add test case for recursive transfer via function argument
fba2918
@SupunS
Merge pull request #2656 from onflow/supun/master-port-internal-128
a393e87 
Add support for max parameter count (internal #128)
@SupunS
Merge pull request #2657 from onflow/supun/master-port-internal-130
563c84b 
Remove spurious resource loss errors (internal #130)
@SupunS
Merge pull request #2658 from onflow/supun/master-port-internal-129
9df8e23 
Fix checking of reference expressions involving optionals (internal #129)
@SupunS
Merge branch 'master' of https://github.com/onflow/cadence into supun…
ee7b48d 
…/master-port-internal-133
@SupunS
Merge pull request #2659 from onflow/supun/master-port-internal-133
bca3e4e 
Prevent recursive transfers (internal #133)
@SupunS
v0.39.14
2bfdc82
@SupunS
Merge pull request #2660 from onflow/supun/bump-version
931e30b 
Bump version to `v0.39.14`
turbolent and others added 20 commits September 26, 2023 15:10
@turbolent
use kr/pretty instead of go-test/deep to prevent empty diffs
9e8068e
@turbolent
Merge pull request #2811 from onflow/bastian/allow-type-injection
10f50bc
@turbolent
remove gocap
74e0b2d
@turbolent
Merge pull request #2819 from onflow/bastian/fix-test-diff
b9b9568 
Use kr/pretty instead of go-test/deep to prevent empty diffs, remove gocap
@SupunS
Merge pull request #2783 from m-Peter/refine-test-framework-api
368d7e3 
Refine API of the testing framework
@turbolent
check native function declarations
4d0836e
@turbolent @SupunS
improve error message
5f185e0 
Co-authored-by: Supun Setunga <[email protected]>
@turbolent
add test case for declaring native function in composite
d174f7b
@turbolent
Merge pull request #2821 from onflow/bastian/check-native-functions
1956c2e 
Check native function declarations
@turbolent
fix swapping in resource array: insert temporary placeholder
88f2e1d
@turbolent
add test case for same indices
de1ec1f
@turbolent
add an explanation for the placeholder insertion
405464a
@turbolent
add new parameter
f1a8ff1
@turbolent
fix swap statement evaluation evaluate all parts (left target, left k…
c6e7139 
…ey, right target, right key), before getting and setting
@turbolent
add tests
6748a7e
@turbolent
lint
6c6f491
@turbolent
Merge pull request #2844 from onflow/bastian/port-internal-141
9e912b9
@turbolent
Merge branch 'master' into bastian/port-internal-144
e998f3e
@turbolent
Merge pull request #2845 from onflow/bastian/port-internal-144
1a082e4
@fxamacker
Merge branch 'master' into fxamacker/sync-atree-register-inlining-bra…
05e8c3e 
…nch-with-master
@fxamacker fxamacker added the Chore label Oct 5, 2023
@fxamacker fxamacker self-assigned this Oct 5, 2023
@fxamacker fxamacker changed the title Sync afeature/atree-register-inlining branch with master branch Sync feature/atree-register-inlining branch with master branch Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/atree-register-inlining commit 7fde56c
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2108µs ± 0%121µs ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-236.4µs ± 0%36.4µs ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsCCF-2150ms ± 0%230ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2535ms ± 0%517ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-25.02µs ± 0%3.30µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-24.40µs ± 0%2.50µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-24.25µs ± 0%3.34µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-23.48µs ± 0%3.53µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-22.53µs ± 0%2.55µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-23.08µs ± 0%3.17µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-23.01µs ± 0%3.03µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-22.96µs ± 0%2.96µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-22.47µs ± 0%2.50µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-23.04µs ± 0%3.06µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-212.6µs ± 0%20.6µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-27.29µs ± 0%11.51µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-211.7µs ± 0%11.3µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-215.7µs ± 0%16.7µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-27.38µs ± 0%7.55µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-29.61µs ± 0%9.39µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-210.7µs ± 0%9.9µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-29.11µs ± 0%9.04µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-27.39µs ± 0%7.25µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-210.1µs ± 0%10.4µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-274.9ms ± 0%75.1ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2181ms ± 0%137ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-21.64µs ± 0%1.62µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-21.27µs ± 0%1.27µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-21.67µs ± 0%1.59µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-21.82µs ± 0%1.82µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.27µs ± 0%1.27µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-21.44µs ± 0%1.50µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-21.56µs ± 0%1.55µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.54µs ± 0%1.52µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-21.33µs ± 0%1.28µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-21.55µs ± 0%1.55µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-23.81µs ± 0%3.31µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-21.84µs ± 0%1.83µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-22.95µs ± 0%2.93µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-24.15µs ± 0%4.17µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-21.86µs ± 0%1.91µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-22.52µs ± 0%2.46µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-22.82µs ± 0%2.84µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-22.20µs ± 0%2.20µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-21.85µs ± 0%1.84µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-22.78µs ± 0%2.88µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2357ns ± 0%365ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-281.7ns ± 0%87.6ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-22.49ms ± 0%2.51ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-21.30µs ± 0%1.34µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2690ns ± 0%685ns ± 0%~(p=1.000 n=1+1)
ParseArray-28.05ms ± 0%8.81ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-212.4ms ± 0%12.2ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-21.29ms ± 0%1.29ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2190µs ± 0%197µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2154µs ± 0%150µs ± 0%~(p=1.000 n=1+1)
ParseInfix-27.58µs ± 0%7.17µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-22.35ns ± 0%2.36ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-2125ns ± 0%125ns ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-25.30ms ± 0%5.32ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-24.67µs ± 0%5.04µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-2358ns ± 0%362ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-2154ns ± 0%146ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-2163ns ± 0%162ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-293.9ns ± 0%92.3ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-249.2kB ± 0%49.3kB ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-223.4kB ± 0%23.4kB ± 0%~(all equal)
DecodeBatchEventsCCF-267.3MB ± 0%67.4MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2246MB ± 0%246MB ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-21.41kB ± 0%1.41kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-21.49kB ± 0%1.49kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-21.50kB ± 0%1.50kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.26kB ± 0%1.26kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-21.38kB ± 0%1.38kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-21.34kB ± 0%1.34kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.33kB ± 0%1.33kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-21.35kB ± 0%1.35kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-26.02kB ± 0%6.02kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-23.62kB ± 0%3.62kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-25.45kB ± 0%5.45kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-27.37kB ± 0%7.37kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-23.66kB ± 0%3.66kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-24.55kB ± 0%4.55kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-24.91kB ± 0%4.91kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-24.49kB ± 0%4.49kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-23.62kB ± 0%3.62kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-24.91kB ± 0%4.91kB ± 0%~(all equal)
EncodeBatchEventsCCF-237.1MB ± 0%37.1MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-234.0MB ± 0%34.0MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-2736B ± 0%736B ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-2800B ± 0%800B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-2768B ± 0%768B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-2704B ± 0%704B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-2784B ± 0%784B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-2752B ± 0%752B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-2736B ± 0%736B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-2752B ± 0%752B ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-2768B ± 0%768B ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-2408B ± 0%408B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2760B ± 0%760B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2952B ± 0%952B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-2424B ± 0%424B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-2624B ± 0%624B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-2680B ± 0%680B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-2544B ± 0%544B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-2416B ± 0%416B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-2672B ± 0%672B ± 0%~(all equal)
ExportType/composite_type-2136B ± 0%136B ± 0%~(all equal)
ExportType/simple_type-20.00B 0.00B ~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(all equal)
NewInterpreter/new_interpreter-2976B ± 0%976B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.65MB ± 0%2.73MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-24.27MB ± 0%4.09MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-228.9kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-228.9kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseInfix-21.91kB ± 0%1.91kB ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeResourceDictionaryValues-22.29MB ± 0%2.29MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-23.02kB ± 0%3.02kB ± 0%~(all equal)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2806 ± 0%812 ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-2370 ± 0%370 ± 0%~(all equal)
DecodeBatchEventsCCF-21.48M ± 0%1.48M ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-24.70M ± 0%4.70M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-232.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-2126 ± 0%126 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-271.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2102 ± 0%102 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2159 ± 0%159 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-270.0 ± 0%70.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-287.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-295.0 ± 0%95.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-286.0 ± 0%86.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-271.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-295.0 ± 0%95.0 ± 0%~(all equal)
EncodeBatchEventsCCF-2467k ± 0%467k ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2757k ± 0%757k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-214.0 ± 0%14.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-223.0 ± 0%23.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-213.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-216.0 ± 0%16.0 ± 0%~(all equal)
ExportType/composite_type-23.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-20.00 0.00 ~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-216.0 ± 0%16.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-289.5k ± 0%89.4k ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-263.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-250.0 ± 0%50.0 ± 0%~(all equal)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

turbolent
turbolent approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent merged commit 1f1e476 into feature/atree-register-inlining Oct 5, 2023
7 of 9 checks passed
@turbolent turbolent deleted the fxamacker/sync-atree-register-inlining-branch-with-master branch October 5, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@fxamacker fxamacker

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fxamacker @turbolent @SupunS @darkdrag00nv2 @dsainati1 @m-Peter @tarakby @PratikDhanave @janezpodhostnik