Atree Inlining & Deduplication with Cadence v0.42 (deprecated by PR #5736) #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update event validation logic to account for the `evm.*` events
…ock-master [Access] add config to limit script execution range - master
[Flow EVM] balance type improvement
…t' of github.com:onflow/flow-go into ramtin/4961-evm-update-balance-in-cadence-smart-contract
Added two flags to execution state extraction program: --extract-payloads-by-address produces a file of payloads for specified accounts or for all accounts instead of checkpoint files --use-payload-as-input uses payload file as input instead of checkpoint files The two new flags don't affect migration and other existing functionaly of state extraction program. These two options only affect input and output of state extraction program. In other words, this can be used to extract migrated payloads or extract as-is payloads for specified accounts.
Co-authored-by: Bastian Müller <[email protected]>
Refactored payload file related functionality to be more reusable. Added flags: --input-payload-filename --output-payload-filename
This utility can be used to create a subset of execution state which can save time during development, testing, and support/troubleshooting.
Co-authored-by: Leo Zhang <[email protected]>
This commit also added --allow-partial-state-from-payload-file flag to execution-state-extract program. User needs to specify this flag allow partial payload file as input (e.g. not all accounts) in order to prevent accidental use of partial state during real migration. The primary use case for payload file is for development, testing, and debugging of migrations because it allows migrating a subset of payloads instead of all payloads.
Currently storage map key is assumed to be StringAtreeValue type. However, storage domain cap_con uses Uint64AtreeValue as storage map key. This commit supports both map key types during atree migration and Cadence value validation.
This commit adds flag "continue-migration-on-validation-errors" to continue migration even if validatino fails. Validation errors are logged before continuing to the next account. This feature should only be used for testing and debugging.
21 tasks
This was referenced Apr 18, 2024
fxamacker
changed the title
|
This PR was useful for fast updates to avoid workflow bottlenecks like unrelated test flakes, etc. Closed by PR #5736 which will be easier for PR reviewers, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge. This PR is to be used for building migration program needed by spork and running benchmarks.
This enables Atree Inlining & Deduplication with Cadence 0.42 in flow-go (e.g. atree migration program, etc.).
TODO:
OPTIONAL TODO:
Update to get recent changes to the migration program
NOTE: Using intermediate payload file during real migration has become low priority (optional) because enabling atree inlining reduces duration of migration (due to reduced node count, payload count, total data size, etc.) 🎉
UPDATES: