Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading libp2p to version v0.14.1 #782

Merged
merged 6 commits into from
Jun 4, 2021

Conversation

vishalchangrani
Copy link
Contributor

@vishalchangrani vishalchangrani commented Jun 3, 2021

Libp2p v0.14.1

The stream reset error that are being reported on mainnet and devnet could be because of the yamux issue.

This change -

  1. Updates libp2p version and associated dependencies which got updated due to go mod tidy.
  2. Replaces the deprecated protofbuf ptypes.TimestampProto method with timestamppb.New.

@vishalchangrani vishalchangrani self-assigned this Jun 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #782 (8e81a55) into master (f1bc65c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   56.42%   56.38%   -0.05%     
==========================================
  Files         423      423              
  Lines       24783    24779       -4     
==========================================
- Hits        13984    13971      -13     
- Misses       8907     8911       +4     
- Partials     1892     1897       +5     
Flag Coverage Δ
unittests 56.38% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/common/rpc/convert/convert.go 34.34% <0.00%> (+0.68%) ⬆️
engine/execution/ingestion/engine.go 52.19% <0.00%> (-2.68%) ⬇️
cmd/util/ledger/migrations/storage_v4.go 42.16% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bc65c...8e81a55. Read the comment docs.

@vishalchangrani vishalchangrani marked this pull request as ready for review June 4, 2021 18:48
@@ -458,10 +458,7 @@ func blockEventsToMessage(block flow.BlockEvents) (*access.EventsResponse_Result
for i, event := range block.Events {
eventMessages[i] = convert.EventToMessage(event)
}
timestamp, err := ptypes.TimestampProto(block.BlockTimestamp)
Copy link
Contributor Author

@vishalchangrani vishalchangrani Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -27,14 +27,15 @@ require (
github.com/ipfs/go-log v1.0.4
github.com/jrick/bitset v1.0.0
github.com/libp2p/go-addr-util v0.0.2
github.com/libp2p/go-libp2p v0.13.0
github.com/libp2p/go-libp2p-core v0.8.0
github.com/libp2p/go-libp2p v0.14.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the crux of the change - go-libp2p

Copy link
Contributor

@yhassanzadeh13 yhassanzadeh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade Vishal.

@vishalchangrani vishalchangrani merged commit 733ff7c into master Jun 4, 2021
@vishalchangrani vishalchangrani deleted the vishal/libp2p_upgrade_to_v0141 branch June 4, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants