Merge pull request #144 from gyKa/fix-scrutinizer

Fix Scrutinizer issues.
ongr-archive · Feb 9, 2015 · 118a64d · 118a64d
2 parents 64364eb + 9958c81
commit 118a64d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/Pipeline/Pipeline.php b/Pipeline/Pipeline.php
@@ -161,7 +161,7 @@ public function setName($name)
     /**
      * Counts number of items in the services.
      *
-     * @param array[] $sources
+     * @param \Traversable[]|array[] $sources
      *
      * @return int
      */

diff --git a/Sync/DiffProvider/Binlog/BinlogDecorator.php b/Sync/DiffProvider/Binlog/BinlogDecorator.php
@@ -126,8 +126,8 @@ protected function retrieveMapping($table)
     /**
      * Applies associative mapping to numbered columns.
      *
-     * @param array $params
-     * @param array $mapping
+     * @param array      $params
+     * @param array|bool $mapping
      *
      * @return array
      */
@@ -157,13 +157,21 @@ public function current()
         $mapping = $this->getTableMapping($diffItem->getCategory());
 
         if (isset($buffer[BinlogParser::PARAM_QUERY]['where'])) {
-            $where = $buffer[BinlogParser::PARAM_QUERY]['where'];
-            $diffItem->setWhereParams($this->applyMapping($where, $mapping));
+            $diffItem->setWhereParams(
+                $this->applyMapping(
+                    $buffer[BinlogParser::PARAM_QUERY]['where'],
+                    $mapping
+                )
+            );
         }
 
         if (isset($buffer[BinlogParser::PARAM_QUERY]['set'])) {
-            $set = $buffer[BinlogParser::PARAM_QUERY]['set'];
-            $diffItem->setSetParams($this->applyMapping($set, $mapping));
+            $diffItem->setSetParams(
+                $this->applyMapping(
+                    $buffer[BinlogParser::PARAM_QUERY]['set'],
+                    $mapping
+                )
+            );
         }
 
         return $diffItem;