Relations #143
Relations #143
Conversation
| @@ -1,6 +1,5 @@ | |||
| parameters: | |||
| # Sql relations classes | |||
| ongr_connections.sql_relations.simple_relation.class: ONGR\ConnectionsBundle\Sync\Extractor\Relation\SimpleSqlRelation | |||
| ongr_connections.sql_relations.composed_relation.class: ONGR\ConnectionsBundle\Sync\Extractor\Relation\ComposedSqlRelation | |||
| ongr_connections.sql_relations.sql_relation.class: ONGR\ConnectionsBundle\Sync\Extractor\Relation\SqlRelation | |||
There was a problem hiding this comment.
sql_relations.sql_relation ? we can do better than that :D
There was a problem hiding this comment.
What would you suggest?
There was a problem hiding this comment.
sql_relations.general_relation
sql_relations.relation
.. maybe somebody has even better ideas
There was a problem hiding this comment.
Let's try to break away from sql_relations in general. What is the function of a sql_relations.sql_relation?
There was a problem hiding this comment.
ongr_connections.sql_relations.sql_relation.class is used by relations example https://github.com/ongr-io/ConnectionsBundle/pull/143/files#diff-0ecea2bd068f83cc8f0d36e45f499f83R33
There was a problem hiding this comment.
After a bit of discussion we (@GrandLTU and myself) have decided that the most fitting name would be extraction_descriptor, since it is a descriptive class used by extractor to extract relevant data (an extraction). What used to be an relation collection would subsequently become extraction collection or simply extractions. What is your opinion about this, @trylika?
| @@ -17,7 +17,7 @@ | |||
| /** | |||
| * Helper base class for adding MySQL parameters to the given definition. | |||
| */ | |||
| abstract class AbstractMySqlPass | |||
| abstract class AbstractExtractorDescriptorPass | |||
There was a problem hiding this comment.
okay, not to nitpick, but maybe AbstractExtractionDescriptorPass?
| Descriptors | ||
| =========== | ||
|
|
||
| Sql descriptors are special classes that tell extractor which fields/tables to watch for changes. |
There was a problem hiding this comment.
Extraction descriptors ... :)
| } elseif (empty($statements)) { | ||
| throw new \LogicException( | ||
| 'Missing relations or no document type set in descriptor "' | ||
| . $descriptor->getName() . '"' |
closes #106