Add typings for window. #2839
Merged
Add typings for window. #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codebase is littered with (window as any).some_field. This diff applies some types. There are two benefits: - More consistency when storing and accessing fields. - Centralized documentation of the global variables.
|
Uffizzi Preview |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(window as any).some_fieldis abundant across the codebase. This diff applies some types using interface merging. There are two benefits:window.some_fieldjust looks a bit nicerTested:
yarn webpackbuilds fine,yarn devhas no errors and looks okay when I visitlocalhost:8080