Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always call callback for service.stop() #41

Closed
wants to merge 1 commit into from
Closed

fix: Always call callback for service.stop() #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lib/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Service, { ServiceConfig, ServiceRecord } from './service'

const REANNOUNCE_MAX_MS : number = 60 * 60 * 1000
const REANNOUNCE_FACTOR : number = 3
const noop = function () {}

export class Registry {

Expand Down Expand Up @@ -42,9 +43,10 @@ export class Registry {
}

function stop(service: Service, registry: Registry, callback?: CallableFunction) {
if (!service.activated) return
if (!callback) callback = noop
if (!service.activated) return process.nextTick(callback)

if(!(service instanceof Service)) return
if(!(service instanceof Service)) return process.nextTick(callback)
registry.teardown(registry.server, service, callback)

const index = registry.services.indexOf(service)
Expand Down