Use opset_version 16 instead of 18 since 16 is the latest supported version #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
jcwchen
commented
Jul 12, 2023
| if start == -1: | ||
| raise Exception(f"Cannot find {cache_name} in {line}.") | ||
| return line[start + len(cache_name) + 1:] | ||
| raise Exception(f"Cannot find Build dir in {stdout}.") |
There was a problem hiding this comment.
Thanks @ramkrishna2910 for the idea. In this PR it will use output to get the cache directory location.
There was a problem hiding this comment.
I would recommend reading the Build dir field directly for the path.
The user can choose to specify --cache-dir in which case .cache will not be in the path.
There was a problem hiding this comment.
Good point. I have updated it to use the last token from split("/"). PTAL. Thanks!
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
Signed-off-by: jcwchen <[email protected]>
jcwchen
requested review from
ramkrishna2910
and removed request for
ramkrishna2910
ramkrishna2910
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use opset_version 16 instead of 18 since 16 is the latest supported version by torch.onnx.export. There are some conversion failures when exporting opset_version 18. Use 16 for now and we will update opset_version in the future.