Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NON FUNCTIONAL CHANGE] Fix spelling, punctuation, and some end of line in onnx-mlir help #2979

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[NON FUNCTIONAL CHANGE] Fix spelling, punctuation, and some end of line in onnx-mlir help #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f1aba0
fix spelling, punctuation, and some end of line in help
AlexandreEichenberger Oct 16, 2024
abc902f
format
AlexandreEichenberger Oct 16, 2024
ae9592d
Merge branch 'main' into help-fix
AlexandreEichenberger Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Accelerators/NNPA/Compiler/NNPACompilerOptions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ llvm::cl::opt<bool> nnpaEnableCompilerStickUnstick(
llvm::cl::opt<bool> nnpaEnableScalarBcastBinary(
"nnpa-enable-scalar-bcast-binary",
llvm::cl::desc("Enable the lowering to NNPA of binary operations with "
"broadcasting of a scalar operand."
"broadcasting of a scalar operand.\n"
"Currently only enable ONNXDiv. Default is false."),
llvm::cl::init(false), llvm::cl::cat(OnnxMlirCommonOptions));

Expand All @@ -70,9 +70,10 @@ llvm::cl::opt<std::string> nnpaLoadDevicePlacementFile{
llvm::cl::desc(
"Load device placement configuration from a JSON file. To "
"have a template for the JSON file, use "
"--nnpa-save-device-placement-file=cfg.json. Note that we can use "
"--nnpa-save-device-placement-file=cfg.json.\nNote that we can use "
"regex for "
"string values in the JSON file to match operations. The compiler uses "
"string values in the JSON file to match operations.\nThe compiler "
"uses "
"C++ std::regex_match function for matching."),
llvm::cl::init(""), llvm::cl::cat(OnnxMlirOptions)};

Expand All @@ -87,11 +88,11 @@ llvm::cl::opt<NNPAPlacementHeuristic> nnpaPlacementHeuristic{
"[Optional] Choose NNPA-related heuristic to place operations "
"on NNPA device:"),
llvm::cl::values(
clEnumVal(QualifyingOps, "Place all qualifying ops on NNPA (default)"),
clEnumVal(FasterOps, "Place qualifying ops that are faster on NNPA"),
clEnumVal(FasterOpsWSU, "FasterOps with stick/unstick cost"),
clEnumVal(QualifyingOps, "Place all qualifying ops on NNPA (default)."),
clEnumVal(FasterOps, "Place qualifying ops that are faster on NNPA."),
clEnumVal(FasterOpsWSU, "FasterOps with stick/unstick cost."),
clEnumVal(MuchFasterOpsWSU,
"Much/Significantly FasterOps with stick/unstick cost")),
"Much/Significantly FasterOps with stick/unstick cost.")),
llvm::cl::init(QualifyingOps), llvm::cl::cat(OnnxMlirOptions)};

llvm::cl::opt<bool> nnpaEnableSaturation("nnpa-saturation",
Expand Down
Loading
Loading