-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --outputs_as_nchw option to transpose output to from nhwc to nchw #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
Signed-off-by: Deyu Huang <[email protected]>
fatcat-z
reviewed
Jul 7, 2022
fatcat-z
reviewed
Jul 7, 2022
hwangdeyu
changed the title
Add --outputs_as_nchw option to transpose output to from nchw to nhwc
Add --outputs_as_nchw option to transpose output to from nhwc to nchw
Jul 7, 2022
fatcat-z
reviewed
Jul 7, 2022
Signed-off-by: Deyu Huang <[email protected]>
fatcat-z
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Deyu Huang <[email protected]>
hwangdeyu
changed the title
Add --outputs_as_nchw option to transpose output to from nhwc to nchw
Implement --outputs_as_nchw option to transpose output to from nhwc to nchw
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1973 #1986
Add a option to make outputs format nhwc to nchw.
tf2onnx only supports
--inputs-as-nchw
for specifying input as nchw so far. However, in some cases, such as models loaded by tensorRT or OpenCV DNN, it also needs to force output to nchw.