Add support to customize junit report config to omit spec labels (#1087)

onsi · Dec 6, 2022 · de44005 · de44005
1 parent a3eed17
commit de44005
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/reporters/junit_report.go b/reporters/junit_report.go
@@ -30,6 +30,9 @@ type JunitReportConfig struct {
 
 	//Enable OmitCapturedStdOutErr to prevent captured stdout/stderr appearing in system-out
 	OmitCapturedStdOutErr bool
+
+	// Enable OmitSpecLabels to prevent labels from appearing in the spec name
+	OmitSpecLabels bool
 }
 
 type JUnitTestSuites struct {
@@ -176,7 +179,7 @@ func GenerateJUnitReportWithConfig(report types.Report, dst string, config Junit
 			name = name + " " + spec.FullText()
 		}
 		labels := spec.Labels()
-		if len(labels) > 0 {
+		if len(labels) > 0 && !config.OmitSpecLabels {
 			name = name + " [" + strings.Join(labels, ", ") + "]"
 		}
 

diff --git a/reporters/junit_report_test.go b/reporters/junit_report_test.go
@@ -219,6 +219,7 @@ var _ = Describe("JunitReport", func() {
 				OmitTimelinesForSpecState: types.SpecStatePassed,
 				OmitFailureMessageAttr:    true,
 				OmitCapturedStdOutErr:     true,
+				OmitSpecLabels:            true,
 			})).Should(Succeed())
 			DeferCleanup(os.Remove, fname)
 
@@ -251,7 +252,7 @@ var _ = Describe("JunitReport", func() {
 			Ω(suite.TestCases).Should(HaveLen(4))
 
 			failingSpec := suite.TestCases[0]
-			Ω(failingSpec.Name).Should(Equal("[It] A B C [dolphin, gorilla, cow, cat, dog]"))
+			Ω(failingSpec.Name).Should(Equal("[It] A B C"))
 			Ω(failingSpec.Classname).Should(Equal("My Suite"))
 			Ω(failingSpec.Status).Should(Equal("timedout"))
 			Ω(failingSpec.Skipped).Should(BeNil())