Add OmitSuiteSetupNodes to JunitReportConfig #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new option to the JunitReportConfig that when enabled prevents the creation of testcase entries for setup nodes in the JUnit report. fix onsi#1145
Added a dummy BeforeSuite spec to validate that with the new OmitSuiteSetupNodes option, the generated JUnit report is omitting this spec and not displaying it as one of the testcases. fix onsi#1145
|
thanks! this LGTM and i'll merge it in once CI finishes |
|
merged! i should be cutting a release that includes this sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to the JunitReportConfig that when enabled prevents the creation of
testcase entries for setup nodes in the JUnit report.
fix #1145