Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code during maven build (protobuf/omt schema) #114

Closed
msbarry opened this issue Mar 5, 2022 · 2 comments · Fixed by #310
Closed

Generate code during maven build (protobuf/omt schema) #114

msbarry opened this issue Mar 5, 2022 · 2 comments · Fixed by #310
Labels
internal Improve the experience for contributors

Comments

@msbarry
Copy link
Contributor

msbarry commented Mar 5, 2022

Ideally we wouldn't check generated code (protobuf and OMT schema) into git and instead generate it on the fly as part of the maven build.

Related to #109

@msbarry msbarry added the internal Improve the experience for contributors label Mar 8, 2022
@wipfli
Copy link
Contributor

wipfli commented Mar 8, 2022

scripts/regenerate-openmaptiles.sh should be easy with the formatting in #122.

scripts/regenerate-protobuf.sh gives me an error:

➜  planetiler git:(eclipse-formatter) ✗ scripts/regenerate-protobuf.sh     
+ echo Regenerating...
Regenerating...
+ protoc --java_out=planetiler-core/src/main/java/ planetiler-core/src/main/resources/vector_tile_proto.proto
scripts/regenerate-protobuf.sh: line 5: protoc: command not found

@wipfli
Copy link
Contributor

wipfli commented Mar 8, 2022

With sudo apt install -y protobuf-compiler on ubuntu, I can also run the protobuf generation script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Improve the experience for contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants