-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newlines to OpenMapTiles table #109
Conversation
This pull request should only insert new lines, i.e., it should only have whitespace changes. |
https://github.com/onthegomap/planetiler/actions/runs/1932983622 ℹ️ Base Logs e93ff79
ℹ️ This Branch Logs 1e76e6f
|
To checkt that this pull request indeed only edited whitespaces, I did the following:
|
Thanks! All of the code in For now I want to make sure that regenerating and auto-formatting generates a consistent output, so can you update the code in In the medium term, we're going to move the openmaptiles profile to the openmaptiles repo, and use regular yaml files to control the tag selection. |
Thanks. I was a bit suspicious of the generated folder :S In MapLibre GL JS we removed generated files from source control because (a) they are not required and (b) cause sometimes confusion with new community members... Should I submit a pull request to remove generated files from source control? |
Oh and I thought, uh poor Mike had to copy all those tags by hand from OMT... |
What were the generated files you removed in maplibre? Did you add a build step to generate them for new users? Removing the generated folder (and generated protobuf files) would make sense, but we'd need to replace that with a maven build step that generates them instead. I haven't looked into that but if you were able to that would be great! The generated code contains:
I think we want to keep 1 and 2, but 3 will eventually go away and be replaced by dynamically parsing the yaml at runtime. |
The style spec is a json document from which we generate |
Closing this for now, since I should better not edit a generated file. |
Adds newlines to the OpenMapTiles table file. My motivation for this is to simplify customization of the basemap profile. For example, with the hot-air balloon I often land in places where it matters if the
highway=track
hastracktype=grade1
ortracktype=grade5
. Thetracktype
tag is not part of OMT, so I added it manually to the basemap profile. It is super fun to customize the tiles like this. After this pull request, adding new tags will only insert a new line and result in a simpler git diff. Merging upstream changes will also be easier.