-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing Basemap Base-Url #143
Conversation
https://github.com/onthegomap/planetiler/actions/runs/2034417429 ℹ️ Base Logs 4c6d5e6
ℹ️ This Branch Logs a741e4e
|
planetiler-basemap/src/main/java/com/onthegomap/planetiler/basemap/Generate.java
Show resolved
Hide resolved
planetiler-basemap/README.md
Outdated
@@ -41,7 +41,7 @@ To run `Generate.java`, use [scripts/regenerate-openmaptiles.sh](../scripts/rege | |||
OpenMapTiles release tag: | |||
|
|||
```bash | |||
./scripts/regenerate-openmaptiles.sh v3.12.2 | |||
./scripts/regenerate-openmaptiles.sh v3.13 https://raw.githubusercontent.com/openmaptiles/openmaptiles/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove the https://raw.githubusercontent.com/openmaptiles/openmaptiles/
arg here since it's optional, and maybe give a second snippet if you want to run it from a fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only in the README or also in the .sh script? I am fine with both 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the readme is fine since the script handles when it is or isn't provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I updated the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for making this change!
This PR allows to change the base-url of the openmaptiles.yml. I also changed the default to v3.13. If you don't want that let me know, I can easily revert that.