-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust multiexpression filtering #206
Merged
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dc6a70f
Add failing test cases
ZeLonewolf 514259b
Add missing NOT key checks
ZeLonewolf d7e275c
Undo unrelated simplify
ZeLonewolf b2ab8a8
Add and/or constant tests
ZeLonewolf 031964b
Merge branch 'logic_tests' into zelonewolf_logic_tests
msbarry e5315b9
More robust multiexpression filtering
msbarry 663282c
move
msbarry 1ee37bb
Add test case for "missing"
ZeLonewolf e21485c
comment
msbarry 1ab5048
Add match not missing test
ZeLonewolf 86dd8ae
Merge branch 'onthegomap:zelonewolf_logic_tests' into zelonewolf_logi…
ZeLonewolf 076a0b2
simplify matchField
msbarry 6712cf9
fix simplify issue
msbarry 88d508d
simplify and() to true
msbarry 0a87abc
Add new test case
ZeLonewolf ce41a24
tweaks
msbarry efdd8ec
0.9
msbarry f25bd56
remove unreachable code
msbarry 80ebb8d
Merge branch 'onthegomap:zelonewolf_logic_tests' into zelonewolf_logi…
ZeLonewolf 04fb8dc
Add test cases
ZeLonewolf 3cc462a
remove empty block
msbarry 12a360b
test some more cases
msbarry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix should be to surround the warn call with
if(LOGGER.isWarnEnabled()) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few cases like this that I think I want to tackle in one pass (and leave highlighted so I don't miss one). I'd prefer to go the route of a logger framework that takes a lambda that only gets invoked if that level is needed. There's also some other logging issues to clear up like
core
should just depend on slf4j and the runnable thing (dist
module or a project that depends on this) should bind slf4j to whatever implementation it wants.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan. Looks like https://github.com/kwon37xi/slf4j-lambda exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also slf4j v2 api will support lambdas. I'd like to use that but it's been in alpha stage since 2019...? https://mvnrepository.com/artifact/org.slf4j/slf4j-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a logging framework, how bad could alpha be? 🤔