-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --feature-read-threads
option to read features in parallel when writing tiles
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/2380981487 ℹ️ Base Logs f5206b3
ℹ️ This Branch Logs 852740f
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163 by adding a
--feature-read-threads
argument that can set how many threads read temp features in parallel during the mbtiles write phase. It defaults to 1 (old behavior) when there are less than 32 cpus, and 2 when there are 32 or more. Some testing on my m1 mac and a c6gd.xlarge instance showed that 2 read threads doubles throughput, and in some situations on some systems 3 can be slightly faster - but usually 2 outperforms 3.Note: when more than 1 read thread is used, it also spawns a "merge" thread to merge the results, so
--feature-read-threads=1
uses 1 thread,--feature-read-threads=2
uses 3 threads,--feature-read-threads=3
uses 4 threads, etc...