-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy primitive group deserialization #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is GC pressure and primitive group? |
https://github.com/onthegomap/planetiler/actions/runs/2753288275 ℹ️ Base Logs c14be44
ℹ️ This Branch Logs 4d609e8
|
I didn't think anyone would read this 😉 ! Updated the description, does that make more sense now? |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LongHashSet
with more memory-efficientRoaring64Bitmap
for storing IDs of ways that are members of multipolygonsPreviously
osm_pass1
was taking ~3 minutes and spending 1.5 minutes in GC, now it takes 1:45-2:00 and spends 14 seconds in GC on a cg6d.metal instance. This also helps running with a smaller heap in memory-mapped mode (which should probably be the default now unlesss you have 150GB+ of RAM).