-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up VarInt encoding, remove emitTilesInOrder option [#98] #460
Conversation
https://github.com/onthegomap/planetiler/actions/runs/4024463087 ℹ️ Base Logs 9ce9d1f
ℹ️ This Branch Logs 7597645
|
Double check for any more references to emit_tiles_in_order, I see one in custtommap readme and planetiler.schema.json. |
* @param v the value to encode | ||
* @param outputStream the OutputStream to add the encoded value | ||
*/ | ||
public static void putVarLong(long v, OutputStream outputStream) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see the outputstream version being useful in other contexts, but if the only purpose of it here is for pmtiles then seems fine to only include what it needs - we can always pull the old version out of git history.
Kudos, SonarCloud Quality Gate passed! |
This changes the user and YML-facing configuration by removing the
emitTilesInOrder
option, should we keep that dead option in there for now?The difference between ordered and unordered MBTiles inserts on a 64 core machine isn't significant:
ordered:
unordered: