Expose pmtiles writer #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/4456711247 ℹ️ Base Logs 9945ad4ℹ️ This Branch Logs 171d090 |
bdon
reviewed
Mar 17, 2023
| assert lastTile == null || lastTile.compareTo(tileCoord) < 0 : "Tiles out of order %s before %s" | ||
| .formatted(lastTile, tileCoord); | ||
| assert lastTile == null || | ||
| order.encode(tileCoord) > order.encode(lastTile) : "Tiles out of order %s before %s" |
There was a problem hiding this comment.
Technically the PMTiles writer can take out-of-order writes and has some logic to set clustered=false and re-sort the entries. If we are enforcing this via assertion then we could take that logic out.
There was a problem hiding this comment.
The assertion only runs when -ea jvm flag is set (including during tests). All of the code within planetiler is designed to output tiles in order so I like having the assertion in here, but if someone uses this utility outside of planetiler then they might not write in order....
msbarry
commented
Mar 18, 2023
| @@ -0,0 +1,75 @@ | |||
| package com.onthegomap.planetiler.archive; | |||
There was a problem hiding this comment.
Not sure if TileArchives utilities for working with tile archives makes the most sense, or collapse TileArchives and TileArchiveMetadata into one record TileArchive that also has static factory methods?
There was a problem hiding this comment.
Seems useful to be able to manipulate metadata not in the context of an entire archive?
There was a problem hiding this comment.
oops sorry I meant collapse TileArchives and TileArchiveConfig into just TileArchive, for example: 17bdd19
|
LGTM! We should also update the README/other doc files about the new output format but that can go in a follow-up |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using new pmtiles writer functionality by changing
--outputargument to point at a file ending in.pmtiles.Major changes:
--output=path.mbtilesor--output=path.pmtilescommand-line argument to control where the output goes.--mbtiles=output.mbtileswill also continue to work until you upgrade from deprecatedsetOutput("mbtiles", path)tosetOutput(path).--compact-db=falsebecomes--output=out.mbtiles?compact=false--skip-mbtiles-index-creationbecomes--output=out.mbtiles?no_index--optimize-dbbecomes--output=out.mbtiles?vacuum_analyzeAlso cleaned up the code since there were quite a few places that assumed mbtiles output:
TileArchiveMetadatathat describes metadata that pmtiles and mbtiles metadata can hold and pulled metadata interface up intoWriteableTileArchiveandReadableTileArchiveinterfaces.TileArchiveConfigthat describes the location, format, and options of a tile archive to write to/read fromTileArchivesutility with static factory methods for creating readable and writable archives