add extraMetadata to profile interface [#794] #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/7554493975 ℹ️ Base Logs 0cb2645ℹ️ This Branch Logs c23e3b6 |
msbarry
reviewed
Jan 16, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/archive/TileArchiveMetadata.java
Outdated
Show resolved
Hide resolved
| @@ -157,6 +158,8 @@ default boolean isOverlay() { | |||
| return false; | |||
| } | |||
|
|
|||
| default Map<String,String> extraMetadata() { return Map.of(); } | |||
There was a problem hiding this comment.
I wonder if we should include archive in the name here to make it clear where the metadata is going?
There was a problem hiding this comment.
changed to extraArchiveMetadata
bdon
force-pushed
the
profile-extra-metadata
branch
from
788515b
to
88c0746
Compare
* simpler implementation of mergeMaps
msbarry
reviewed
Jan 17, 2024
| @@ -93,7 +96,7 @@ public TileArchiveMetadata(Profile profile, PlanetilerConfig config, List<LayerA | |||
| config.minzoom(), | |||
| config.maxzoom(), | |||
| vectorLayers == null ? null : new TileArchiveMetadataJson(vectorLayers), | |||
| mapWithBuildInfo(), | |||
| mergeMaps(mapWithBuildInfo(),profile.extraArchiveMetadata()), | |||
There was a problem hiding this comment.
I think I'd expect the profile to provide defaults, then args to layer on top of that, so let's either reverse this or the behavior of mergeMaps?
There was a problem hiding this comment.
shouldn't mapWithBuildInfo just be the planetiler:* metadata? If I define those in my profile (or command line args passed into my profile), they ought to override the defaults, I don't know why someone would do that though.
There was a problem hiding this comment.
Oh right! Yeah this looks good then. The command-line args get copied in just above this.
msbarry
reviewed
Jan 17, 2024
| @@ -93,7 +96,7 @@ public TileArchiveMetadata(Profile profile, PlanetilerConfig config, List<LayerA | |||
| config.minzoom(), | |||
| config.maxzoom(), | |||
| vectorLayers == null ? null : new TileArchiveMetadataJson(vectorLayers), | |||
| mapWithBuildInfo(), | |||
| mergeMaps(mapWithBuildInfo(),profile.extraArchiveMetadata()), | |||
There was a problem hiding this comment.
Oh right! Yeah this looks good then. The command-line args get copied in just above this.
Comment on lines
21
to
22
| import java.util.stream.Collectors; | ||
| import java.util.stream.Stream; |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.