Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update home page design #235

Merged
merged 54 commits into from
May 26, 2023
Merged

Feature: Update home page design #235

merged 54 commits into from
May 26, 2023

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Apr 19, 2023 •
edited
Loading

Problems

  • Two calls to action with the same weight (the two search fields)
  • Bad styling
  • The presence of unimportant sections like: notes, slices

What did I do

  • Use just one search field that does the job of the previous two
  • Remove the unimportant sections
  • A better styling

Screenshots

Home.mp4

@Bilelkihal Bilelkihal added the enhancement New feature or request label Apr 19, 2023
@Bilelkihal Bilelkihal self-assigned this Apr 19, 2023
@Bilelkihal Bilelkihal marked this pull request as draft April 19, 2023 10:24
@syphax-bouazzouni
Copy link
Collaborator

@Bilelkihal why is this PR still in draft mode?

@Bilelkihal
Copy link
Collaborator Author

I'm still working on the search field

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/update-home-page-design branch from cfb4f45 to 30ee286 Compare May 4, 2023 08:21
@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented May 4, 2023 •
edited
Loading

@Bilelkihal, I added this two commits:

  • optimize and remove the unused methods in the home index action(4c24d5c)
  • replace the two services buttons with a toggle input (30ee286)
Enregistrement.de.l.ecran.2023-05-04.a.10.24.13.mov

syphax-bouazzouni
syphax-bouazzouni requested changes May 4, 2023
View reviewed changes
app/assets/stylesheets/home.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/home.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/home.scss Show resolved Hide resolved
app/controllers/home_controller.rb Outdated Show resolved Hide resolved
app/views/home/index.html.haml Outdated Show resolved Hide resolved
app/views/home/index.html.haml Show resolved Hide resolved
app/views/home/index.html.haml Outdated Show resolved Hide resolved
@syphax-bouazzouni syphax-bouazzouni linked an issue May 8, 2023 that may be closed by this pull request
Refactor the home page design #222
Closed
4 tasks
syphax-bouazzouni and others added 10 commits May 22, 2023 15:32
syphax-bouazzouni
syphax-bouazzouni requested changes May 23, 2023
View reviewed changes
app/views/home/index.html.haml Outdated Show resolved Hide resolved
syphax-bouazzouni
syphax-bouazzouni requested changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the remaining details

@Bilelkihal
Copy link
Collaborator Author

Done ✅

@Bilelkihal Bilelkihal merged commit 9934fc7 into development May 26, 2023
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Jun 27, 2023
Merged
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Jul 22, 2023
Merged
This was referenced Sep 2, 2023
Closed
Merged
syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023
@syphax-bouazzouni
Merge pull request #235 from ontoportal-lirmm/feature/update-home-pag…
77093cc 
…e-design

Feature: Update home page design
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphax-bouazzouni syphax-bouazzouni Awaiting requested review from syphax-bouazzouni

Assignees

@Bilelkihal Bilelkihal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the home page design
2 participants
@Bilelkihal @syphax-bouazzouni