Feature: add column ontologies count to categories and-groups admin page #254

SirineMhedhbi · 2023-05-24T15:20:58Z

Context

See agroportal/project-management#422

Changes

Add column number of ontologies in groups and categories table .
Add pop-up with list of ontologies in group and category admin table.
Change the column from nb to count in group and category admin table.
Redirect the click on the groups/categories ontologies count link to the browse page with the correct filter applied.
Add a select to update ontologies in edit pop-up in category/group table.
Restyle edit pop-up in category/group in admin table.
Resolve problem of delete all ontologies in category/group edit.

…min table" This reverts commit c4b391a.

…n table

…dmin table

Resolves #254

syphax-bouazzouni

Good job, just some small details to change, and then we are good to go.

syphax-bouazzouni · 2023-06-15T09:29:56Z

app/controllers/admin/categories_controller.rb

+    @name = "category[ontologies]"
+    @values = @ontologies_category
+    @selected = @category.ontologies
+    @multiple = true


you don't need the @id, @name, @values, @selected nad @multiple variable directly put the values in the view;

syphax-bouazzouni · 2023-06-15T09:31:33Z

app/controllers/admin/categories_controller.rb

@@ -20,7 +20,13 @@ def new
  end

  def edit
-    @category = LinkedData::Client::Models::Category.find_by_acronym(params[:id]).first
+    @category = LinkedData::Client::Models::Category.find_by_acronym(params[:id], include:'name,acronym,created,description,parentCategory,ontologies' ).first
+    @ontologies_category = LinkedData::Client::Models::Ontology.all.map {|o|[o.acronym, o.id] }


Change to

@ontologies_category = LinkedData::Client::Models::Ontology.all(include: 'acronym').map {|o|[o.acronym, o.id] }

to make the query more efficient.

syphax-bouazzouni · 2023-06-15T09:33:21Z

app/controllers/admin/categories_controller.rb

@@ -49,10 +55,11 @@ def update
    response = { errors: '', success: ''}
    start = Time.now
    begin
-      category = LinkedData::Client::Models::Category.find_by_acronym(params[:id]).first
+      category = LinkedData::Client::Models::Category.find_by_acronym(params[:id], include:'name,acronym,created,description,parentCategory,ontologies' ).first


extract 'name,acronym,created,description,parentCategory,ontologies' into a constant a re-use it in the line 106

syphax-bouazzouni · 2023-06-15T09:34:13Z

app/controllers/admin/categories_controller.rb

@@ -105,4 +112,23 @@ def _categories
    end
    response
  end
+
+  def add_ontologies_to_category(ontologies,hasDomain)


the same code as in groups, extract it into a concern and re-use it for groups

syphax-bouazzouni · 2023-06-15T09:34:38Z

app/controllers/admin/groups_controller.rb

-
+    @acronyms = @group.ontologies.map { |url| url.match(/\/([^\/]+)$/)[1] }
+    @ontologies_group = LinkedData::Client::Models::Ontology.all.map {|o|[o.acronym, o.id] }
+    @id = "group_ontologies"


same remark as in categories

syphax-bouazzouni · 2023-06-15T09:35:10Z

app/views/admin/categories/_form.html.haml

+        %th
+          Ontologies
+        %td.top
+          = render SelectInputComponent.new(id: @id, name: @name, values: @values , selected: @selected , multiple: @multiple, hide: true)


why hide it?

we just need the select

OK, you need to make the variable name more clear, from hide to 'open_to_add_values' or something like this

syphax-bouazzouni · 2023-06-15T09:38:37Z

app/controllers/admin/groups_controller.rb

+
+  def add_ontologies_to_group(ontologies,group)
+    ontologies.each do |ont|
+      unless group.ontologies.include?(ont)


instead of doing

unless condition # your code end

do this

next if condition # your code

…unt-to-group-and-category Feature: add column ontologies count to categories and-groups admin page

… and Bug fixes (#335) * Merge pull request #281 from ontoportal-lirmm/fix-bug-in-slices-links fix bug in slices links * Merge pull request #212 from ontoportal-lirmm/fix/signup-fields-validation Fix: Signup page input fields validation * Merge pull request #214 from ontoportal-lirmm/feature/update-account-page-design Feature: Update submited ontologies and created projet sections design * Merge pull request #237 from ontoportal-lirmm/feature/ecoportal/groups-categories-administration Feature: Add categories and groups administration * Merge pull request #273 from ontoportal-lirmm/fix/bug-ANAEETHES-ontology Fix: Ontology description text display when it is a complex object not a string * Merge pull request #277 from ontoportal-lirmm/Fix-alphabetical-sorting Fix: Alphabetical sorting in the the collection members display * Fix: bug of display list submitted ontologies of account setting (#286) * fix display list of views of ontologies in Submitted ontologies #270 * fix bug of display text in alert when there is no collections (#285) fix the alert message text that is wrapping and overflowing out #266 * Merge pull request #287 from ontoportal-lirmm/fix-bug-reset-password Fix: bug of reset password * Fix bug of select list view of ontology (#289) * Add Chosen.js functionality to fix bug of select views of ontolgy * Add Chosen.js functionality for list views ontologies * fix bug of update ontology where there is no view * Refactor code * Delete ponse = @ontology.update * Merge pull request #295 from ontoportal-lirmm/Fix-display-the-list-of-concepts-in-a-collection-at-one-sight Fix: display the list of concepts in a collection at one sight * Merge pull request #291 from ontoportal-lirmm/Fix-remove-views-of-submitted-ontologies-in-account-setting Fix: Remove views ontologies in list of submitted ontologies * Merge pull request #280 from ontoportal-lirmm/Fix-Ontology-style-text-display-when-it-is-uri Fix: ontology style text display when it is uri * Merge pull request #254 from ontoportal-lirmm/feature/add-ontology-count-to-group-and-category Feature: add column ontologies count to categories and-groups admin page * Merge pull request #302 from ontoportal-lirmm/feature/migrate-fair-score-js-code Feature: Migrate fair score JS code to Stimulus controllers * fix generated bug after edit group and category (#334) --------- Co-authored-by: SirineMhedhbi <[email protected]>

add column ontologies count to categories and-groups admin page

1bd65de

SirineMhedhbi requested a review from syphax-bouazzouni May 24, 2023 15:21

SirineMhedhbi added 7 commits May 31, 2023 15:47

change the name of column count from nb to count in group/category table

9110911

add a pop-up with list of ontologies in group and category admin table

c4b391a

Revert "add a pop-up with list of ontologies in group and category ad…

65d4750

…min table" This reverts commit c4b391a.

add a hide to SelectInputComponent

556205e

add a select to update ontologies in the pop-up edit of group in admi…

bee8da3

…n table

add a select to update ontologies in the pop-up edit of category in a…

7dec801

…dmin table

resolve problem of delete all ontologies, restyle edit in category/group

fefd0f1

syphax-bouazzouni pushed a commit that referenced this pull request Jun 14, 2023

Enable sorting for ontology-level mappings tabs

5e1b27d

Resolves #254

syphax-bouazzouni requested changes Jun 15, 2023

View reviewed changes

SirineMhedhbi added 3 commits June 15, 2023 18:48

Refactor code

50dec75

Rename hide in select input component

4586043

refactor code and fix bug

1edfd79

syphax-bouazzouni mentioned this pull request Jun 24, 2023

Expected behaviour with multiple mapped properties with different types agroportal/project-management#425

Closed

syphax-bouazzouni approved these changes Jun 27, 2023

View reviewed changes

syphax-bouazzouni merged commit 98e6b02 into development Jun 27, 2023

SirineMhedhbi mentioned this pull request Jul 12, 2023

Merge to master - Release 2.7.0.3 - New UI, Multilingual integration, New metadata mode and docker images #240

Merged

syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023

Merge pull request #254 from ontoportal-lirmm/feature/add-ontology-co…

0121b16

…unt-to-group-and-category Feature: add column ontologies count to categories and-groups admin page

syphax-bouazzouni mentioned this pull request Sep 5, 2023

Merge to master: Release 2.4.7 - Groups and categories administration and Bug fixes #335

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: add column ontologies count to categories and-groups admin page #254

Feature: add column ontologies count to categories and-groups admin page #254

SirineMhedhbi commented May 24, 2023 •

edited

Loading

syphax-bouazzouni left a comment

syphax-bouazzouni Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

SirineMhedhbi Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

SirineMhedhbi Jun 15, 2023

syphax-bouazzouni Jun 15, 2023

Feature: add column ontologies count to categories and-groups admin page #254

Feature: add column ontologies count to categories and-groups admin page #254

Conversation

SirineMhedhbi commented May 24, 2023 • edited Loading

Context

Changes

syphax-bouazzouni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SirineMhedhbi commented May 24, 2023 •

edited

Loading