Merge to master: Release 2.5.1 - New metadata models and new upload & edit submission UIs #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use inline svg in file input loader component * add hint to text input component * add error state to input field component * add helper text to input field component * add notes to input field component to explain how to use it * combine text area input component with input field component * groupe inputs in one folder in the lookbook * fix style issues in input field component * refactor input field component code to remove repetition * remove the duplicated alert component preview * make the input field component generic using a the content slot * implement form date component * implement form text area component * implement form text input component * duplicate the select component to be in the "form" namespace * fix select input component inversed open_to_add_values argument usage * move and rename file input loader component to be in the form module * update select component to use InputFieldComponent to have a label * remove unsed text in NestedFormInputComponentPreview * Fix bug of select list view of ontology (#289) * Add Chosen.js functionality to fix bug of select views of ontolgy * Add Chosen.js functionality for list views ontologies * fix bug of update ontology where there is no view * Refactor code * Delete ponse = @ontology.update * fix nested form component inputs focus color to use primary variable * add upload ontology from style file * extract from upload ontology from the location partial * update upload ontology form design * make the upload ontology form button style apply also submit button * add id argument to chips components to permit having multiple chips with same name * fix label not showing for the from select component * put the correct input names in the new ontology form * replace the finish div in the new ontology form with a submit tag * use for the administrated_by input with the form select component * implement the backend create action for the new upload ontology form * fix text area component not showing the value given as argument * add the default values for the inputs in the new ontology form * extract submission_from_params method from the save_submission concern * handle new ontology upload errors in the create action * add default empty submission in the new action * add type parametre to text_input_component so we can specify type as email, number .. * make nested form component start by default by one form initialized * add URI field to the upload ontology process * add search input component * add ontology search input component re-using search-input component * re-use ontology search input component in the topnav * re-use the ontology-search-input in the home * update search-input component to make it more generic * rename view components "form" namespace to "input" * create the display namespace for the data display components * create the layout namespace for view component that structure content * use the table component in the ontology mappings tab * add table component (style, preview and code) * make dropdown content. with no default padding * update concept details component to use the Table and dropdown component * add concept details component preview * update collection, concept, label_xl and scheme views with the new concept details component * migrate notes table to use Table component * install tom select * update select component with tom select * use not centred layout for the select input previews * remove the select id in the select input component template * remove is_selected_value variable in the select input component * fix select component id * add pill button component * add loader component small option and previews * update ontology subscribe component design and add preview * move rounded button preview to the button namespace * extract modal helpers into a helper file * use the new modal helpers instead of writing the view component or frame * add option to modal to show in connect alone * add modal component style * add modal component preview * move the modal component preview into the layout namespace * Update the design of the switch component * add switch input component preview * update search input component to handle custom link turbo targets * update search input component to have form-control style by default * remove no used home search controller replaced with search input * fix. ontology search input component ajax_url argument to add ?acronym= * fix home page search input style * migrate search input style from home.scss to search_input.scss * add margin top and bottom for the nested form component * update nested form component to have an empty state to send to the back * handle contact nested form empty state * migrate the fair score js code to stimulus to make it work with turbo * remove the old fair_score.js code * fix home page responsiveness issues * fix footer responsiveness * fix nav bar responsiveness and add admin to nav items * fix home annotator/recommender section title * fix home responsiveness for small screens * add link text component * use link text component to implement popup link component * use link text component to implement external link component * use link text component to implement internal link component * use internal and external links component in the label link component * add previews to link text components * change internal link icon in link text component tmp tmp tmp tmp tmp tmp tmp tmp tmp tmp * refactor select input component template to use the rails helper * use stimulus values in select input component controller * Add email, password, url components to lookbook * use url component in upload ontology process * fix location subform selection via text on upload ontology * change date of creation by modification date field, and add comment of changes field when upload new version of an ontology * fix select input component to use the name * use the correct name for the visibility and allowed to view inputs * make ontology edit and new form use multi part * fix URI input name and value to replace ontology by submission * add disable state to input field component * make acronym field disabled when uploading a new version of an ontology * migrate the ontology picker single partial to select component * Add the checked property to the chips component * update date component with flatpicker * add disabled state to input field component * update submission helpers with the new components * refactor update ontology code to remove undesired ifs * add text field and text area components to lookbook * add select component to lookbook * add date field to the lookbook * add "inline_svg" gem to use svg in files * make the components preview container include JS cod if needed * add language field component * add link field component * add date_time field component * add license field component * add text area field component * add summary section component preview * add dropdown component * add field container component to show a label with it's value vertically * add nested form input component preview * add a pop-up with list of ontologies in group and category admin table * Revert "add a pop-up with list of ontologies in group and category admin table" This reverts commit c4b391a. * add a select to update ontologies in the pop-up edit of group in admin table * add a select to update ontologies in the pop-up edit of category in admin table * Refactor code * refactor code and fix bug * remove old undesired text area input from lookbook * add Upload file input component to lookbook * combine all input components in one globale component * remove style params from input field component * recover text area field component (after deleting it by mistake in a previous commit * add hint to text input component * add error state to input field component * add helper text to input field component * add notes to input field component to explain how to use it * combine text area input component with input field component * groupe inputs in one folder in the lookbook * make the input field component generic using a the content slot * implement form date component * implement form text area component * implement form text input component * duplicate the select component to be in the "form" namespace * move and rename file input loader component to be in the form module * update select component to use InputFieldComponent to have a label * remove unsed text in NestedFormInputComponentPreview * fix nested form component inputs focus color to use primary variable * add upload ontology from style file * extract from upload ontology from the location partial * update upload ontology form design * make the upload ontology form button style apply also submit button * add id argument to chips components to permit having multiple chips with same name * fix label not showing for the from select component * put the correct input names in the new ontology form * replace the finish div in the new ontology form with a submit tag * use for the administrated_by input with the form select component * implement the backend create action for the new upload ontology form * fix text area component not showing the value given as argument * add the default values for the inputs in the new ontology form * extract submission_from_params method from the save_submission concern * handle new ontology upload errors in the create action * add default empty submission in the new action * add type parametre to text_input_component so we can specify type as email, number .. * make nested form component start by default by one form initialized * add URI field to the upload ontology process * rename view components "form" namespace to "input" * create the display namespace for the data display components * create the layout namespace for view component that structure content * add modal component preview * move the modal component preview into the layout namespace * change internal link icon in link text component tmp tmp tmp tmp tmp tmp tmp tmp tmp tmp * add text field and text area components to lookbook * add date field to the lookbook * fix label not showing for the from select component * fix text area component not showing the value given as argument * add type parametre to text_input_component so we can specify type as email, number .. * refactor select input component template to use the rails helper * use stimulus values in select input component controller * Add email, password, url components to lookbook * use url component in upload ontology process * fix location subform selection via text on upload ontology * fix select input component to use the name * use the correct name for the visibility and allowed to view inputs * make ontology edit and new form use multi part * fix URI input name and value to replace ontology by submission * migrate the ontology picker single partial to select component * Add the checked property to the chips component * Merge remote-tracking branch 'origin/feature/update-upload-ontology' into feature/update-upload-ontology * change date of creation by modification date field, and add comment of changes field when upload new version of an ontology * add disable state to input field component * update submission helpers with the new components * refactor update ontology code to remove undesired ifs * add id parameter to input field component * replace finish button in upload ontology by the button component * Add size parameter to button component * Add color parameter to button component * Add state parameter to the button component * make finish button animated in upload ontology process * add progress pages component * put again the type argument for button component * fix progress pages item not center if test is long * migrate upload ontology form to use progress pages component * make progress pages container take full width by default * update login page button component usage to have an ID * put again the removed JS code for visibility and is a view * fix chips style padding removed from merging with the browse branch * update date input in the ontology form to use the metadata helper * fix chips style in upload ontology form * remove old new submission form from the bottom of the new ontology page * Fix select multiple items, delete icon style in select component * fix upload ontology style to have less margin bottom * extract ontology updater and saver concern form ontologies controller code * update submission create action tu update also the ontology * use AlertComponent to display ontology form error messages * create input helpers to use inputs component more easily and use them in ontology form * remove no more used style code in upload ontology style file * fix ontology form date and contact inputs not showing error message * set update ontology to true in the create action of submission controller * fix alignement of chips and button components --------- Co-authored-by: Syphax Bouazzouni <[email protected]> Co-authored-by: SirineMhedhbi <[email protected]> Co-authored-by: Sirine Mhedhbi <[email protected]>
* remove the unnecessaire variable is_selected_value from the select component haml file * update submission form content to use attributes category not display * make submission edit frame have a custom id from params * extract submission form attributes category array * fix submission from tabs style by removing the old edit-ontology-tab cls * fix edit ontology tabs style * fix edit submission error * install tippy js for the hover notes * Add see the wiki sentence in edit ontology page * replace edit ontology buttons with component button * make reset all fields button works in edit ontology page * Make input field label font size bigger (12px --> 14px) * add data attribute for select and text components * handle for the input field component the case attributes are nil * remove no more used form group component and text field component * add a label argument for nest agent input component * make summary licenses popup use attr_label instead of attribute_infos * fix tom select hidden input style to not take full width * extract useTomSelect component tom select controller * update search input component to use InputFieldComponent * update input field help text slot to support raw html display * update submission location form JS to use 'var' instead of 'const' to make it work even if the partial is re-render again in the same context (turbo frame reload) * remove old submission contact and location form partials * update ontology picker single to use select input helper * use attr_label instead of generate_attribute_label helper in the metadata curator table header * redirect ontology edit action to submission controller new or edit * replace metadata selector component with a helper method * update ontology form partial to have only ontology attributes in it * update ontology new template to add submission attributes in it directly * fix regular button display animation by adding as argument a loader id * update inputs helpers to add the arguments data, id and help * extract from ontology and submission form the metadata_help_link helper * update submission new action to redirect to the ontology new template * add submission edit_properties action for a list of submission attributes * add ontology details tab to the submission form * add metadata and submission inputs helpers files * simplify the submission form content and remove no more used helpers * show in the submission edit action the new submission form template * simplify the submission format form and use the new input helpers * make the select component inline rendered * update tooltip to use Tippy.js * add tooltip popovers for submission attribute inputs * move submission form partial to the edit template * transform EditSubmissionAttributeButtonComponent to a helper function * add the button "add new submission" to the ontology viewer header * remove no more used ontology controller update action * fix nested turbo frame to be hidden when a parent frame is busy/loading * create error_message_alert helper to display an alert with erroneous fields * add required asteriks to submission attribute that enforce existence * make the submission location form partial work for existing submission * fix submission format form partial syle * transform submission form_content the view that display update errors * fix ontology form hasDomain and group inputs that can't be reset empty * make selected_attribute? helper work for equivalent or direct attribute * move back some code logic from ontology updated concern to controllers * create render_submission_inputs helper to display inputs components * use the default template of submissions controller edit action * disable submission form categories tabs when the properties filter used * handle submission pullLocation parameter update depending of isRemote * update submission update controller to add ontology update step * fix ontology metadata curator to use the new submission form * remove submission new template, replaced with ontologies new * make attr_header_label use a custom label as argument * add title to new and edit submission buttons in the ontology viewer * put again the removed margin top of summary section only in summary page * move submission_metadata to metadata_helper and application_controller files * have custom labels for summary submission table header * hide tooltip from attribute labels in the summary section * remove the add et edit submission button in front the submissions table * remove useless ontology value in submission updater * redirect edit page to home if user not connected * remove default today value from date input --------- Co-authored-by: Bilel Kihal <[email protected]>
syphax-bouazzouni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Context
Changes