Docker: Remove explicit CUDA 11.8 Reference #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiteadam
changed the title
|
Can you replace cu118 with cu121 instead of removing it? For future-proofness when a new pytorch version gets released. |
|
It is done and tested. I am curious about the impact on this line, though. |
|
This one can be changed as well, as this file exists under bitsandbytes. Thanks for pointing out and for the fixes. |
|
This unfortunately breaks compatibility with debian stable as the latest driver only supports up to cuda 12.0. Users trying to run this without a server gpu (which supports forward compatibility) receive a weird error message. Could we keep a second dockerfile with 11.8 with instructions in the readme for that use case ? I would be happy to make a pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @bdashore3 added CUDA 12.1 images, the explicit CUDA 11.8 ref for Torch set by @sammcj is no longer needed.
I tested this build locally with RTX 3060 and found no issues (other than a DEPRECATION NOTICE! from NVIDIA on 12.1).
Checklist: