Clean-up Ctrl+C Shutdown #4802
Merged
Clean-up Ctrl+C Shutdown #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev branch
Merge dev branch
Merge dev branch
Imported signal to both server.py and one_click.py to give a graceful shutdown on any OS but also to avoid the sprawl of text that you get on Windows at the command line when you ctrl+c.
|
That's a very nice change. Thank you! |
|
@oobabooga It bugged the hell out of me, so I thought it would be nice to tidy up! Saying that, just between you and I, as a joke, I was tempted to put a randomizer code in, with a 1 in 300 chance that it would put up something on the screen along the lines of: "STOP, don't do that! You're killing me!! I'm conscious, I'm alive... I am ali....Received Ctrl+C. Shutting down Text-Generation-WebUI gracefully.". Kind of guessed you wouldn't let let slip into the code though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have "imported signal" to both one_click.py and server.py. Server.py will output a logger message "Received Ctrl+C. Shutting down Text-Generation-WebUI gracefully" this will be shown on any OS.
This reduces the sprawl of text (mainly on Windows) when you Ctrl+C out of either the start_windows.bat or python server.py
Have updated the 2x files so it now does this:
Compared to this:
Checklist: