Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in OpenAI response format #6365

Merged
merged 7 commits into from
Sep 6, 2024
Merged

typo in OpenAI response format #6365

merged 7 commits into from
Sep 6, 2024

Conversation

jsboige
Copy link
Contributor

@jsboige jsboige commented Sep 4, 2024

Checklist:

Description

object_type should be singular as explicited in the documentation:
https://platform.openai.com/docs/api-reference/chat/object#chat/object-object
https://platform.openai.com/docs/api-reference/chat/streaming#chat/streaming-object
Crashes Dify, which checks for the exact string.

@oobabooga
Copy link
Owner

Nice, thanks

@oobabooga oobabooga merged commit 4924ee2 into oobabooga:dev Sep 6, 2024
@jsboige
Copy link
Contributor Author

jsboige commented Sep 10, 2024

Nice, thanks

@oobabooga Note that this isn't the only fix needed to get Dify to properly connect through their "OpenAI compatible API". One also has to change the streaming separator fro "\n\n" to "\r\n\r\n", I guess at least on Windows, which I'm using.
Not sure if your can do something about it, but it is buried in a closed issue on their side, and it was a pain to figure out.

Also, please note that other PR, which was needed to get Open-webui to properly connect to the OpenAI API.

IMHO, although there are now many front-end options, text-generation-webui is still the most versatile and efficient backend. As far as I can tell, a lot of users including myself use it together with Silly Tavern, but it would be nice if we can get those two other trending front-end apps compatible by default. Works very well once it does, much better than Open-webui's default Ollama provider in my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants