Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make bootstrap more robust (and slower 😢) #1351

Merged
merged 6 commits into from
Oct 9, 2023
Merged

fix: make bootstrap more robust (and slower 😢) #1351

merged 6 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. fix: make bootstrap more robust (and slower) 

    This diff ensures that the boostrap is more robust in the scenario
described by ooni/probe#2544.

Because we're close to a release, I did not want to write a heavy
refactor of the boostrap, and specifically of the iplookup part, but
I documented what is needed at ooni/probe#2551.

This diff has been tested in a problematic network under two
distinct conditions:

1. cold bootstrap (i.e., w/o prior knowledge), where the correct
fix is to give the system resolver intermediate priority;

2. hot bootstrap with fscked up config, where the correct fix
is to use a large coarse grained timeout.

The fix that causes a canceled context to prevent marking a resolver
as failed helps in both scenarios.

As you can see, I removed a "reliability fix", which actually was
more of an optimization. This removal means that the probe bootstrap
is now slower than it could be, hence my choice of documenting
what I'd do had I had more time to work on this topic.
    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    aaf4802 View commit details
    Browse the repository at this point in the history

  2. x

    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3540eee View commit details
    Browse the repository at this point in the history

  3. x

    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f81badf View commit details
    Browse the repository at this point in the history

  4. x

    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c5b9aed View commit details
    Browse the repository at this point in the history

  5. x

    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d98251b View commit details
    Browse the repository at this point in the history

  6. x

    @bassosimone
    bassosimone committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1137e85 View commit details
    Browse the repository at this point in the history