feat(dslx): introduce MeasureResolvedAddresses #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
bassosimone
commented
Oct 25, 2023
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff introduces MeasureResolvedAddresses and other ancillary functions that allow us to express measuring endpoints in a very simple way and with less code than with previous dslx code. As a result, we can deprecate a bunch of dslx functions (we will actually clean them up at a later time). While there, make StreamList simpler and more efficient: we can stream w/o creating a goroutine. It suffices to create a sufficiently buffered channel and fill it, and we can do all the work in the current goroutine. While there, fix a bug where QUICHandshake was mistakenly using the host network rather than the measuring network to create UDP listening sockets, which, well..., generated lots of confusion for me 😅 🤦. While there, make sure the netemx.MustNewScenario function creates HTTP/3 listeners for DNS servers. Previously, we did not create such listeners, which however is necessary because we very often use DoH3. While there, make sure we have issues for upcoming work. Closes ooni/probe#2618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff introduces MeasureResolvedAddresses and other ancillary functions that allow us to express measuring endpoints in a very simple way and with less code than with previous dslx code.
As a result, we can deprecate a bunch of dslx functions (we will actually clean them up at a later time).
While there, make StreamList simpler and more efficient: we can stream w/o creating a goroutine. It suffices to create a sufficiently buffered channel and fill it, and we can do all the work in the current goroutine.
While there, fix a bug where QUICHandshake was mistakenly using the host network rather than the measuring network to create UDP listening sockets, which, well..., generated lots of confusion for me 😅 🤦.
While there, make sure the netemx.MustNewScenario function creates HTTP/3 listeners for DNS servers. Previously, we did not create such listeners, which however is necessary because we very often use DoH3.
While there, make sure we have issues for upcoming work.
Closes ooni/probe#2618.