feat(minipipeline): add ControlFinalResponseExpectations #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: internal/minipipeline/analysis.go
bassosimone
added a commit
that referenced
this pull request
Jan 19, 2024
This diff completes the work started by #1451 by adding support for ControlFinalResponseExpectations to the analysis data structures, which will enable us to use this information for Web Connectivity LTE. Part of ooni/probe#2640.
bassosimone
added a commit
that referenced
this pull request
Jan 19, 2024
We need to know about all possible unexplained failures. With this information and information about ControlFinalResponseExpectations introduced in #1451 and #1452, we are able to transform unexplained failures (i.e., failures occurring during redirects) into explained failures when we have a control-based expectation to compare to. Part of ooni/probe#2640
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This PR adds the ControlFinalResponseExpectations field to WebObservationsContainer. We need this field to determine whether unexplained failures observed by the probe (i.e., failures occurring during redirects) are to be expected (because for some reason also the TH failed) or unexpected (because the TH succeeded). Part of ooni/probe#2640.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…1452) This diff completes the work started by ooni#1451 by adding support for ControlFinalResponseExpectations to the analysis data structures, which will enable us to use this information for Web Connectivity LTE. Part of ooni/probe#2640.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
We need to know about all possible unexplained failures. With this information and information about ControlFinalResponseExpectations introduced in ooni#1451 and ooni#1452, we are able to transform unexplained failures (i.e., failures occurring during redirects) into explained failures when we have a control-based expectation to compare to. Part of ooni/probe#2640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ControlFinalResponseExpectations field to WebObservationsContainer. We need this field to determine whether unexplained failures observed by the probe (i.e., failures occurring during redirects) are to be expected (because for some reason also the TH failed) or unexpected (because the TH succeeded).
Part of ooni/probe#2640.