Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(webconnectivitylte): add large file test cases #1475

Merged
merged 5 commits into from
Jan 31, 2024
Merged

chore(webconnectivitylte): add large file test cases #1475

merged 5 commits into from
Jan 31, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jan 25, 2024 •
edited
Loading

@bassosimone bassosimone mentioned this pull request Jan 25, 2024
Closed
@bassosimone
Copy link
Contributor Author

bassosimone commented Jan 31, 2024 •
edited
Loading

So, I instrumented the place where we read bodies for the largeFileHTTPS case and I see:

2024/01/31 18:22:59 BONSOIR, ELLIOT: maxbody=524288, len(body)=524288, err=<nil>

This means that the maxbody and the body length are equal. Why do we fail to set body_is_truncated?

Plot twist, the measurement has the correct value for body_is_truncated.

Ladies and gentleman, it seems we have a case of... PEBCAK!

I prepared a fix for this PEBCAK at #1481.

bassosimone added a commit that referenced this pull request Jan 31, 2024
@bassosimone
minipipeline: fix computing HTTPResponseBodyIsTruncated
9fc8a2c 
Part of ooni/probe#1336

See #1475 (comment)
@bassosimone bassosimone mentioned this pull request Jan 31, 2024
Merged
bassosimone added a commit that referenced this pull request Jan 31, 2024
@bassosimone
minipipeline: fix computing HTTPResponseBodyIsTruncated (#1481)
bf471b3 
Part of ooni/probe#1336

See #1475 (comment)

While there, generate missing minipipeline test cases.

While there, update minipipeline test cases.
@bassosimone bassosimone marked this pull request as ready for review January 31, 2024 17:45
@bassosimone bassosimone changed the title fix(webconnectivitylte): handle truncated bodies chore(webconnectivitylte): add large file test cases Jan 31, 2024
@bassosimone bassosimone merged commit 9b59892 into master Jan 31, 2024
9 checks passed
@bassosimone bassosimone deleted the issue/1336 branch January 31, 2024 18:03
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
@bassosimone @Murphy-OrangeMud
minipipeline: fix computing HTTPResponseBodyIsTruncated (ooni#1481)
ef127a7 
Part of ooni/probe#1336

See ooni#1475 (comment)

While there, generate missing minipipeline test cases.

While there, update minipipeline test cases.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore(webconnectivitylte): add large file test cases (ooni#1475)
e30e816 
Close ooni/probe#1336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine: http-diff for http://www.wougnet.org/
1 participant
@bassosimone