fix(webconnectivitylte): handle malformed redirect URLs #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff ensures that webconnectivitylte is able to handle malformed redirect URLs such as (literally) `http://` and `https://`. The way in which we do this is slightly different from v0.4 and possibly more accurate in that it attributes the error to the operation where we detect the error rather than later on in the next redirect. Because of that, I made the QA suite conform to v0.5's behavior. Closes ooni/probe#2628
4 tasks
bassosimone
added a commit
to ooni/spec
that referenced
this pull request
Jan 31, 2024
…285) ## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2628 - [x] related ooni/probe-cli pull request: ooni/probe-cli#1480 - [x] If I changed a spec, I also bumped its version number and/or date: not needed
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff ensures that webconnectivitylte is able to handle malformed redirect URLs such as (literally) `http://` and `https://`. The way in which we do this is slightly different from v0.4 and possibly more accurate in that it attributes the error to the operation where we detect the error rather than later on in the next redirect. Because of that, I made the QA suite conform to v0.5's behavior. Closes ooni/probe#2628 Related ooni/spec PR: ooni/spec#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff ensures that webconnectivitylte is able to handle malformed redirect URLs such as (literally)
http://andhttps://.The way in which we do this is slightly different from v0.4 and possibly more accurate in that it attributes the error to the operation where we detect the error rather than later on in the next redirect.
Because of that, I made the QA suite conform to v0.5's behavior.
Closes ooni/probe#2628
Related ooni/spec PR: ooni/spec#285