Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webconnectivitylte): don't use a DoH URL provider singleton #1508

Merged
merged 3 commits into from
Feb 12, 2024
Merged

fix(webconnectivitylte): don't use a DoH URL provider singleton #1508

merged 3 commits into from
Feb 12, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Feb 12, 2024 •
edited
Loading

Using a singleton makes tests non-deterministic. Instead use an instance for each measurer.

Helps with ooni/probe#2677.

@bassosimone bassosimone changed the title Issue/2677d fix(webconnectivitylte): don't use a DoH URL provider singleton Feb 12, 2024
@bassosimone bassosimone merged commit f5bacf3 into master Feb 12, 2024
25 checks passed
@bassosimone bassosimone deleted the issue/2677d branch February 12, 2024 19:56
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(webconnectivitylte): don't use a DoH URL provider singleton (ooni…
d0b85d0 
…#1508)

Using a singleton makes tests non-deterministic. Instead use an instance
for each measurer.

Helps with ooni/probe#2677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone