Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webconnectivityqa): use httpclientx #1589

Merged
merged 90 commits into from
May 6, 2024
Merged

Commits on Apr 22, 2024

  1. refactor: consolidate httpx and httpapi

    This diff includes a first attempt at consolidating the patterns with
    which we invoke OONI and third-party API calls.
    
    I have refactored the code of httpx and httpapi into a new package
    called httpclientx, added some tests, started converting some parts
    of the tree, and explained myself in a design document.
    
    Part of ooni/probe#2700
    bassosimone committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    75ef7fd View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    f9210ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    587290c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af394c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6f2f5a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    68c9779 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    57e29da View commit details
    Browse the repository at this point in the history
  7. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5c953f0 View commit details
    Browse the repository at this point in the history
  8. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e03e810 View commit details
    Browse the repository at this point in the history
  9. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a6046fd View commit details
    Browse the repository at this point in the history
  10. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    341fcf2 View commit details
    Browse the repository at this point in the history
  11. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8c34524 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4b464ff View commit details
    Browse the repository at this point in the history
  13. fix: make sure there is nil safety

    Spotted thanks to a very paranoid check inside ./internal/oonirun.
    
    Was not a problem before for `httpx` because of its usage pattern and may
    or may not be a problem for the `httpapi` package (did not check since
    this work is focused on replacing both `httpx` and `httpapi`).
    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6d57184 View commit details
    Browse the repository at this point in the history
  14. oxford comma: yes/no?

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9c2a226 View commit details
    Browse the repository at this point in the history
  15. x

    bassosimone committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1123b4e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. fix: unit test needs to be adapted

    Previously, we were gracefully handling this case, but honestly it is
    not the best approach to pretend there's an empty structure if the server
    breaks the API and returns `"null"` rather than an object.
    
    That said, it was still awesome to have this test in place because it
    helped us to figure out this extra condition of which httpclientx should
    be aware and that this problem needs to be dealt with systematically
    inside the httpclientx package.
    bassosimone committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d421d24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67e0a10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a69d981 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/enginelocate/cloudflare.go
    	internal/enginelocate/ubuntu.go
    bassosimone committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    cd25c56 View commit details
    Browse the repository at this point in the history
  5. x

    bassosimone committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    642ae5c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    548e6bc View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/oonirun/v2_test.go
    bassosimone committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    40db0e5 View commit details
    Browse the repository at this point in the history
  8. start improving probeservices tests

    As before, here I am going to ensure there's redundancy.
    bassosimone committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4cf3566 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    e736e42 View commit details
    Browse the repository at this point in the history
  2. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e8471c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa1c836 View commit details
    Browse the repository at this point in the history
  4. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    08e81a9 View commit details
    Browse the repository at this point in the history
  5. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fa74b48 View commit details
    Browse the repository at this point in the history
  6. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a7e748f View commit details
    Browse the repository at this point in the history
  7. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    87146cc View commit details
    Browse the repository at this point in the history
  8. x

    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    dac7b8f View commit details
    Browse the repository at this point in the history
  9. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/httpclientx/DESIGN.md
    	internal/httpclientx/getraw.go
    	internal/httpclientx/overlapped.go
    bassosimone committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    04b0071 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    79d1fee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88b399d View commit details
    Browse the repository at this point in the history
  3. x

    bassosimone committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    de23e7d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/probeservices/login_test.go
    bassosimone committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9d87673 View commit details
    Browse the repository at this point in the history
  5. x

    bassosimone committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a436f1e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    08f8ca9 View commit details
    Browse the repository at this point in the history
  7. x

    bassosimone committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    25140f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    1bbe0b7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/testingx/oonicollector.go
    bassosimone committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6707d61 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/probeservices/collector_test.go
    bassosimone committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4ddd507 View commit details
    Browse the repository at this point in the history
  4. x

    bassosimone committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c453ee2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/probeservices/bouncer.go
    	internal/probeservices/collector.go
    	internal/probeservices/login.go
    	internal/probeservices/measurementmeta.go
    	internal/probeservices/psiphon.go
    	internal/probeservices/register.go
    	internal/probeservices/tor.go
    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ad3d84f View commit details
    Browse the repository at this point in the history
  2. feat(probeservices): use httpclientx for check-in

    While there, add additional tests ensuring that we're actually
    writing into the key-value store after check-in.
    
    Also, ensure that failure to write into the key-value store
    does not break check-in for good.
    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    28d64f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2107750 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2c8ebf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    36610a8 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/legacy/mockable/mockable.go
    	internal/mocks/session.go
    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b7ccf2f View commit details
    Browse the repository at this point in the history
  7. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b94a8b8 View commit details
    Browse the repository at this point in the history
  8. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5f1994c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6e16369 View commit details
    Browse the repository at this point in the history
  10. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8400bde View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    117fcc2 View commit details
    Browse the repository at this point in the history
  12. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    17f9b83 View commit details
    Browse the repository at this point in the history
  13. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8ca93f0 View commit details
    Browse the repository at this point in the history
  14. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/httpclientx/endpoint.go
    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    854da9a View commit details
    Browse the repository at this point in the history
  15. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f78e32d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5a32450 View commit details
    Browse the repository at this point in the history
  17. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    eb47e28 View commit details
    Browse the repository at this point in the history
  18. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dbb7d6e View commit details
    Browse the repository at this point in the history
  19. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c63e68d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1c55710 View commit details
    Browse the repository at this point in the history
  21. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b461aa4 View commit details
    Browse the repository at this point in the history
  22. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    421f179 View commit details
    Browse the repository at this point in the history
  23. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2a44cd5 View commit details
    Browse the repository at this point in the history
  24. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    13777ba View commit details
    Browse the repository at this point in the history
  25. x

    bassosimone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a4fb49e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cdd0e72 View commit details
    Browse the repository at this point in the history
  2. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0594703 View commit details
    Browse the repository at this point in the history
  3. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0b693ce View commit details
    Browse the repository at this point in the history
  4. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bf35e09 View commit details
    Browse the repository at this point in the history
  5. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9c94348 View commit details
    Browse the repository at this point in the history
  6. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8de9e6b View commit details
    Browse the repository at this point in the history
  7. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    857ff1f View commit details
    Browse the repository at this point in the history
  8. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    08691b3 View commit details
    Browse the repository at this point in the history
  9. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b5ef086 View commit details
    Browse the repository at this point in the history
  10. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9c87724 View commit details
    Browse the repository at this point in the history
  11. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c857375 View commit details
    Browse the repository at this point in the history
  12. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9051155 View commit details
    Browse the repository at this point in the history
  13. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/httpclientx/overlapped.go
    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    60749d0 View commit details
    Browse the repository at this point in the history
  14. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d99bb15 View commit details
    Browse the repository at this point in the history
  15. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fad03f7 View commit details
    Browse the repository at this point in the history
  16. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8fc01d8 View commit details
    Browse the repository at this point in the history
  17. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/httpapi/sequence.go
    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    210393d View commit details
    Browse the repository at this point in the history
  18. Merge branch 'master' into issue/2700

    Conflicts:
    	internal/httpclientx/config_test.go
    	internal/httpclientx/httpclientx_test.go
    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    64ae237 View commit details
    Browse the repository at this point in the history
  19. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b24c13c View commit details
    Browse the repository at this point in the history
  20. x

    bassosimone committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f550fff View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. x

    bassosimone committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6acfecf View commit details
    Browse the repository at this point in the history