-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(webconnectivityqa): use httpclientx #1589
Commits on Apr 22, 2024
-
refactor: consolidate httpx and httpapi
This diff includes a first attempt at consolidating the patterns with which we invoke OONI and third-party API calls. I have refactored the code of httpx and httpapi into a new package called httpclientx, added some tests, started converting some parts of the tree, and explained myself in a design document. Part of ooni/probe#2700
Configuration menu - View commit details
-
Copy full SHA for 75ef7fd - Browse repository at this point
Copy the full SHA 75ef7fdView commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f9210ec - Browse repository at this point
Copy the full SHA f9210ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 587290c - Browse repository at this point
Copy the full SHA 587290cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af394c2 - Browse repository at this point
Copy the full SHA af394c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f2f5a - Browse repository at this point
Copy the full SHA c6f2f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c9779 - Browse repository at this point
Copy the full SHA 68c9779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57e29da - Browse repository at this point
Copy the full SHA 57e29daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c953f0 - Browse repository at this point
Copy the full SHA 5c953f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e03e810 - Browse repository at this point
Copy the full SHA e03e810View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6046fd - Browse repository at this point
Copy the full SHA a6046fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 341fcf2 - Browse repository at this point
Copy the full SHA 341fcf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c34524 - Browse repository at this point
Copy the full SHA 8c34524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b464ff - Browse repository at this point
Copy the full SHA 4b464ffView commit details -
fix: make sure there is nil safety
Spotted thanks to a very paranoid check inside ./internal/oonirun. Was not a problem before for `httpx` because of its usage pattern and may or may not be a problem for the `httpapi` package (did not check since this work is focused on replacing both `httpx` and `httpapi`).
Configuration menu - View commit details
-
Copy full SHA for 6d57184 - Browse repository at this point
Copy the full SHA 6d57184View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c2a226 - Browse repository at this point
Copy the full SHA 9c2a226View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1123b4e - Browse repository at this point
Copy the full SHA 1123b4eView commit details
Commits on Apr 24, 2024
-
fix: unit test needs to be adapted
Previously, we were gracefully handling this case, but honestly it is not the best approach to pretend there's an empty structure if the server breaks the API and returns `"null"` rather than an object. That said, it was still awesome to have this test in place because it helped us to figure out this extra condition of which httpclientx should be aware and that this problem needs to be dealt with systematically inside the httpclientx package.
Configuration menu - View commit details
-
Copy full SHA for d421d24 - Browse repository at this point
Copy the full SHA d421d24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67e0a10 - Browse repository at this point
Copy the full SHA 67e0a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for a69d981 - Browse repository at this point
Copy the full SHA a69d981View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/enginelocate/cloudflare.go internal/enginelocate/ubuntu.go
Configuration menu - View commit details
-
Copy full SHA for cd25c56 - Browse repository at this point
Copy the full SHA cd25c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 642ae5c - Browse repository at this point
Copy the full SHA 642ae5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 548e6bc - Browse repository at this point
Copy the full SHA 548e6bcView commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/oonirun/v2_test.go
Configuration menu - View commit details
-
Copy full SHA for 40db0e5 - Browse repository at this point
Copy the full SHA 40db0e5View commit details -
start improving probeservices tests
As before, here I am going to ensure there's redundancy.
Configuration menu - View commit details
-
Copy full SHA for 4cf3566 - Browse repository at this point
Copy the full SHA 4cf3566View commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e736e42 - Browse repository at this point
Copy the full SHA e736e42View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8471c4 - Browse repository at this point
Copy the full SHA e8471c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa1c836 - Browse repository at this point
Copy the full SHA aa1c836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08e81a9 - Browse repository at this point
Copy the full SHA 08e81a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa74b48 - Browse repository at this point
Copy the full SHA fa74b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7e748f - Browse repository at this point
Copy the full SHA a7e748fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87146cc - Browse repository at this point
Copy the full SHA 87146ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for dac7b8f - Browse repository at this point
Copy the full SHA dac7b8fView commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/httpclientx/DESIGN.md internal/httpclientx/getraw.go internal/httpclientx/overlapped.go
Configuration menu - View commit details
-
Copy full SHA for 04b0071 - Browse repository at this point
Copy the full SHA 04b0071View commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79d1fee - Browse repository at this point
Copy the full SHA 79d1feeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88b399d - Browse repository at this point
Copy the full SHA 88b399dView commit details -
Configuration menu - View commit details
-
Copy full SHA for de23e7d - Browse repository at this point
Copy the full SHA de23e7dView commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/probeservices/login_test.go
Configuration menu - View commit details
-
Copy full SHA for 9d87673 - Browse repository at this point
Copy the full SHA 9d87673View commit details -
Configuration menu - View commit details
-
Copy full SHA for a436f1e - Browse repository at this point
Copy the full SHA a436f1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08f8ca9 - Browse repository at this point
Copy the full SHA 08f8ca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25140f3 - Browse repository at this point
Copy the full SHA 25140f3View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1bbe0b7 - Browse repository at this point
Copy the full SHA 1bbe0b7View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/testingx/oonicollector.go
Configuration menu - View commit details
-
Copy full SHA for 6707d61 - Browse repository at this point
Copy the full SHA 6707d61View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/probeservices/collector_test.go
Configuration menu - View commit details
-
Copy full SHA for 4ddd507 - Browse repository at this point
Copy the full SHA 4ddd507View commit details -
Configuration menu - View commit details
-
Copy full SHA for c453ee2 - Browse repository at this point
Copy the full SHA c453ee2View commit details
Commits on May 2, 2024
-
Merge branch 'master' into issue/2700
Conflicts: internal/probeservices/bouncer.go internal/probeservices/collector.go internal/probeservices/login.go internal/probeservices/measurementmeta.go internal/probeservices/psiphon.go internal/probeservices/register.go internal/probeservices/tor.go
Configuration menu - View commit details
-
Copy full SHA for ad3d84f - Browse repository at this point
Copy the full SHA ad3d84fView commit details -
feat(probeservices): use httpclientx for check-in
While there, add additional tests ensuring that we're actually writing into the key-value store after check-in. Also, ensure that failure to write into the key-value store does not break check-in for good.
Configuration menu - View commit details
-
Copy full SHA for 28d64f1 - Browse repository at this point
Copy the full SHA 28d64f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2107750 - Browse repository at this point
Copy the full SHA 2107750View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2c8ebf - Browse repository at this point
Copy the full SHA c2c8ebfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36610a8 - Browse repository at this point
Copy the full SHA 36610a8View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/legacy/mockable/mockable.go internal/mocks/session.go
Configuration menu - View commit details
-
Copy full SHA for b7ccf2f - Browse repository at this point
Copy the full SHA b7ccf2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b94a8b8 - Browse repository at this point
Copy the full SHA b94a8b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f1994c - Browse repository at this point
Copy the full SHA 5f1994cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e16369 - Browse repository at this point
Copy the full SHA 6e16369View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8400bde - Browse repository at this point
Copy the full SHA 8400bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 117fcc2 - Browse repository at this point
Copy the full SHA 117fcc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f9b83 - Browse repository at this point
Copy the full SHA 17f9b83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ca93f0 - Browse repository at this point
Copy the full SHA 8ca93f0View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/httpclientx/endpoint.go
Configuration menu - View commit details
-
Copy full SHA for 854da9a - Browse repository at this point
Copy the full SHA 854da9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f78e32d - Browse repository at this point
Copy the full SHA f78e32dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a32450 - Browse repository at this point
Copy the full SHA 5a32450View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb47e28 - Browse repository at this point
Copy the full SHA eb47e28View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb7d6e - Browse repository at this point
Copy the full SHA dbb7d6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c63e68d - Browse repository at this point
Copy the full SHA c63e68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c55710 - Browse repository at this point
Copy the full SHA 1c55710View commit details -
Configuration menu - View commit details
-
Copy full SHA for b461aa4 - Browse repository at this point
Copy the full SHA b461aa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 421f179 - Browse repository at this point
Copy the full SHA 421f179View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a44cd5 - Browse repository at this point
Copy the full SHA 2a44cd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13777ba - Browse repository at this point
Copy the full SHA 13777baView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4fb49e - Browse repository at this point
Copy the full SHA a4fb49eView commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cdd0e72 - Browse repository at this point
Copy the full SHA cdd0e72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0594703 - Browse repository at this point
Copy the full SHA 0594703View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b693ce - Browse repository at this point
Copy the full SHA 0b693ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf35e09 - Browse repository at this point
Copy the full SHA bf35e09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c94348 - Browse repository at this point
Copy the full SHA 9c94348View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8de9e6b - Browse repository at this point
Copy the full SHA 8de9e6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 857ff1f - Browse repository at this point
Copy the full SHA 857ff1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08691b3 - Browse repository at this point
Copy the full SHA 08691b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5ef086 - Browse repository at this point
Copy the full SHA b5ef086View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c87724 - Browse repository at this point
Copy the full SHA 9c87724View commit details -
Configuration menu - View commit details
-
Copy full SHA for c857375 - Browse repository at this point
Copy the full SHA c857375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9051155 - Browse repository at this point
Copy the full SHA 9051155View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/httpclientx/overlapped.go
Configuration menu - View commit details
-
Copy full SHA for 60749d0 - Browse repository at this point
Copy the full SHA 60749d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d99bb15 - Browse repository at this point
Copy the full SHA d99bb15View commit details -
Configuration menu - View commit details
-
Copy full SHA for fad03f7 - Browse repository at this point
Copy the full SHA fad03f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc01d8 - Browse repository at this point
Copy the full SHA 8fc01d8View commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/httpapi/sequence.go
Configuration menu - View commit details
-
Copy full SHA for 210393d - Browse repository at this point
Copy the full SHA 210393dView commit details -
Merge branch 'master' into issue/2700
Conflicts: internal/httpclientx/config_test.go internal/httpclientx/httpclientx_test.go
Configuration menu - View commit details
-
Copy full SHA for 64ae237 - Browse repository at this point
Copy the full SHA 64ae237View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24c13c - Browse repository at this point
Copy the full SHA b24c13cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f550fff - Browse repository at this point
Copy the full SHA f550fffView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6acfecf - Browse repository at this point
Copy the full SHA 6acfecfView commit details