Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(oonirun): remove unused testing-hook argument #1610

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Conversation

bassosimone
Copy link
Contributor

This diff removes an unused argument from a testing hook. Removing this argument simplifies the implementation of the richer input patches and does not change the behavior in any way since the argument wasn't used.

Part of ooni/probe#2607.

@bassosimone bassosimone requested a review from hellais as a code owner June 4, 2024 15:34
@DecFox
Copy link
Contributor

DecFox commented Jun 4, 2024

LGTM!

@bassosimone bassosimone merged commit c12991a into master Jun 4, 2024
17 of 18 checks passed
@bassosimone bassosimone deleted the invctrl6 branch June 4, 2024 15:42
@bassosimone bassosimone added the 2024-06-richer-input Tracking 2024-06 richer input work label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-06-richer-input Tracking 2024-06 richer input work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants