Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dnscheck loader #1640

Merged
merged 1 commit into from
Aug 6, 2024
Merged

refactor: remove dnscheck loader #1640

merged 1 commit into from
Aug 6, 2024

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Aug 6, 2024

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

This diff refactors the dnscheck factory to use the default target loader

@DecFox DecFox requested a review from hellais as a code owner August 6, 2024 19:02
@DecFox
Copy link
Contributor Author

DecFox commented Aug 6, 2024

The tests seem to be failing due to the ams-pg-test.ooni.org backend being down now. A fix has been pushed here: #1641

@DecFox DecFox merged commit 26a49ca into master Aug 6, 2024
16 of 20 checks passed
@DecFox DecFox deleted the refactor/dnscheck-richer-input branch August 6, 2024 20:02
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DecFox