Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dslx: use Runtime to save Observations #2614

Closed
bassosimone opened this issue Oct 25, 2023 · 0 comments · Fixed by ooni/probe-cli#1383
Closed

dslx: use Runtime to save Observations #2614

bassosimone opened this issue Oct 25, 2023 · 0 comments · Fixed by ooni/probe-cli#1383
Assignees
@bassosimone
Labels
cleanup There's need to cleanup stuff a bit funder/drl2022-2024 ooni/probe-engine priority/medium refactoring techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

Rather than merging Observations when returning from functions, which is very nice and functional, we should be more pragmatic, strive for simpler code, and use the Runtime to save observations.

The overall objective here is to cleanup and review dslx, then start using it in production and rewrite experiments using it. In turn, by doing that, we'll enable collecting better throttling metrics for experiments.
@bassosimone bassosimone self-assigned this Oct 25, 2023
@bassosimone bassosimone added priority/medium refactoring ooni/probe-engine techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit funder/drl2022-2024 labels Oct 25, 2023
@bassosimone bassosimone mentioned this issue Oct 25, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 25, 2023
@bassosimone
refactor(dslx): collect observations using runtime (#1383)
966a45d 
Closes ooni/probe#2614
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 25, 2023
@bassosimone
fix(dslx): remove Observations from Maybe
55fbc28 
I forgot to commit this diff as part of #1383.

Doing it now.

Reference issue: ooni/probe#2614.
@bassosimone bassosimone mentioned this issue Oct 25, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 25, 2023
@bassosimone
fix(dslx): remove Observations from Maybe (#1385)
0b12f51 
I forgot to commit this diff as part of
#1383.

Doing it now.

Reference issue: ooni/probe#2614.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor(dslx): collect observations using runtime (ooni#1383)
c55096b 
Closes ooni/probe#2614
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(dslx): remove Observations from Maybe (ooni#1385)
e6ed7a2 
I forgot to commit this diff as part of
ooni#1383.

Doing it now.

Reference issue: ooni/probe#2614.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
cleanup There's need to cleanup stuff a bit funder/drl2022-2024 ooni/probe-engine priority/medium refactoring techdebt This issue describes technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dslx): collect observations using runtime ooni/probe-cli
1 participant
@bassosimone