Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request (miniooni): add ability to pass authentication headers #2757

Closed
ainghazal opened this issue Jun 25, 2024 · 0 comments · Fixed by ooni/probe-cli#1627
Closed

feature request (miniooni): add ability to pass authentication headers #2757

ainghazal opened this issue Jun 25, 2024 · 0 comments · Fixed by ooni/probe-cli#1627
Labels
bug Something isn't working triage

Comments

@ainghazal
Copy link

While working on vpn experiments, I thought it would be useful to allow for non-public oonirun descriptors.

Passing an Authentication header as an optional command-line flag would be a simple way of achieving this goal.
@ainghazal ainghazal added bug Something isn't working triage labels Jun 25, 2024
@ainghazal ainghazal mentioned this issue Jun 25, 2024
Merged
4 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Jun 27, 2024
@ainghazal @bassosimone
feat(miniooni): add authentication to oonirun (#1627)
a73c754 
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2757
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
- [x] if you changed code inside an experiment, make sure you bump its
version number


## Description

This commit adds a flag to pass an authentication bearer token to the
miniooni oonirun invocation.

Closes ooni/probe#2757.

---------

Co-authored-by: Simone Basso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(miniooni): add authentication to oonirun ainghazal/probe-cli
1 participant
@ainghazal