Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richer input: correctly serialize options #2763

Closed
bassosimone opened this issue Jun 27, 2024 · 0 comments · Fixed by ooni/probe-cli#1630
Closed

richer input: correctly serialize options #2763

bassosimone opened this issue Jun 27, 2024 · 0 comments · Fixed by ooni/probe-cli#1630
Assignees
Labels
bug Something isn't working funder/drl2022-2024 ooni/probe-engine priority/high techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

This is an issue I noticed while using @ainghazal openvpn experiment. Basically, the way in which we serialize options so far only accounts for when they're provided with -O key=value from the command line. However, the proper thing to do would be to always serialize richer input options directly from the richer input target into the measurement. Incidentally, this enables performing additional transformations while loading richer input, which is a nice-to-have property, as suggested by @ainghazal in a private conversation. When going back and looking at the richer input code, I noticed that I had already flagged this as a TODO for later, but it seems important to do now to submit a meaningful measurement for openvpn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working funder/drl2022-2024 ooni/probe-engine priority/high techdebt This issue describes technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant