Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set options from richer input #1630

Merged
merged 33 commits into from
Jun 28, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jun 26, 2024

While there, update the living design document with features and fixes implemented in this sprint.

Closes ooni/probe#2763.

@bassosimone bassosimone marked this pull request as ready for review June 27, 2024 14:18
@bassosimone bassosimone changed the title feat: correctly set options from richer input fix: correctly set options from richer input Jun 27, 2024
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bassosimone bassosimone merged commit 74e0161 into master Jun 28, 2024
19 checks passed
@bassosimone bassosimone deleted the ri-correctly-set-options branch June 28, 2024 04:58
@bassosimone bassosimone added the 2024-06-richer-input Tracking 2024-06 richer input work label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-06-richer-input Tracking 2024-06 richer input work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

richer input: correctly serialize options
2 participants