Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify openvpn nettest specification to conform to df-009-tunnel #295

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

ainghazal
Copy link
Contributor

Checklist

Description

Modify spec to comply with the semantics of df-009-tunnel

@ainghazal ainghazal changed the title Openvpn tunnel modify openvpn nettest specification to conform to df-009-tunnel Jul 2, 2024
DecFox pushed a commit to ooni/probe-cli that referenced this pull request Jul 19, 2024
…hake failure (#1632)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2758
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
ooni/spec#295
- [x] if you changed code inside an experiment, make sure you bump its
version number


## Description

Add `bootstrap_time` as a top-level test-key, making OpenVPN nettest
conforming to `df-009-tunnel`. It also adds `tunnel` and `failure` keys
with the semantics declared in that spec.
@DecFox DecFox requested review from DecFox and removed request for bassosimone July 19, 2024 10:49
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DecFox DecFox merged commit a655d01 into ooni:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants