Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding changed handler on observer creator #72

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Fix adding changed handler on observer creator #72

merged 1 commit into from
Mar 31, 2016

Conversation

rclai
Copy link
Contributor

@rclai rclai commented Dec 17, 2015

The DDP message parser is looking for an observer.changed function, but if you register a changed function via the observe function as the third argument, it gets registered as updated instead of changed and will throw when an update comes through.

@vsivsi
Copy link
Member

vsivsi commented Mar 31, 2016

Looks good. Thanks!

@vsivsi vsivsi merged commit 6a37c0e into oortcloud:master Mar 31, 2016
vsivsi added a commit that referenced this pull request Mar 31, 2016
@vsivsi
Prepare for 0.12.0 release.
d221554 
  - Update npm dependencies, including faye-websocket (#78)
  - Catch JSON parsing exceptions (#77)
  - Fix adding changed handler on observer creator (#72)
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclai @vsivsi