Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings, minor #78

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Docstrings, minor #78

merged 6 commits into from
Feb 29, 2024

Conversation

MischaPanch
Copy link
Collaborator

I slightly rephrased some normalisation-rule related things, maybe the only part that needs looking at

@MischaPanch
Copy link
Collaborator Author

In the end the PR does introduce minor changes in functionality (fixes), pls have a look at the commit message in 87d12e7

@opcode81
Copy link
Owner

@MischaPanch I rebased and force-pushed the branch to clean up the history. If you approve, feel free to merge this any time.

@opcode81
DFTNormalisation:
fb0ee89 
 * Improve docstrings/comments
 * Improve type hints
 * Add parameters 'array_valued' and 'fit' to RuleTemplate
@MischaPanch MischaPanch merged commit a31e62d into develop Feb 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opcode81 opcode81 Awaiting requested review from opcode81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MischaPanch @opcode81