Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matcher implementation #6

Merged
merged 4 commits into from
Sep 21, 2023
Merged

matcher implementation #6

merged 4 commits into from
Sep 21, 2023

Conversation

itroyano
Copy link
Collaborator

To determine actual state of each resource mad.
Fixes #4

@exe-prow-github-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itroyano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@exe-prow-github-app exe-prow-github-app bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2023
@itroyano itroyano marked this pull request as draft August 20, 2023 14:29
@exe-prow-github-app exe-prow-github-app bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2023
@itroyano
Copy link
Collaborator Author

Fails in debug since match(desiredObject, actualObject, false) tries to compare a HasMetadata that has spec, with a GenericKubernetesResource that doesn't (or rather does, under "additionalProperties", but the matcher doesn't know that).

Working to resolve this.

@itroyano
Copy link
Collaborator Author

UPDATE: related to fabric8io/kubernetes-client#3816
cc: @skattoju

@itroyano
Copy link
Collaborator Author

UPDATE2:

First working diff with an update to the latest JOSDK (see pom.xml diff).

2023-09-21 14:28:54,349 INFO  [io.opd.ExampleValuesReconciler] (ReconcilerExecutor-examplevaluesreconciler-165) Skipping resource kind: Service with name: test-resource-example-chart since it already matches desired state

Thanks @csviri !

@itroyano itroyano marked this pull request as ready for review September 21, 2023 11:37
@exe-prow-github-app exe-prow-github-app bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@itroyano itroyano merged commit e0dcca1 into main Sep 21, 2023
1 check was pending
@itroyano itroyano deleted the compareState branch September 21, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement diff with existing state
2 participants