Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean local images before test #471

Merged
merged 2 commits into from
Aug 13, 2024
Merged

clean local images before test #471

merged 2 commits into from
Aug 13, 2024

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Aug 13, 2024

Description

Clean test images before test

Issues

To avoid issue like this case, the image build failed, but test still pass due to the local exist images from other test.
image

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@chensuyue chensuyue changed the title clean test images before test clean local images before test Aug 13, 2024
@ZePan110 ZePan110 merged commit f36629a into main Aug 13, 2024
11 checks passed
@ZePan110 ZePan110 deleted the suyue/fix_issue branch August 13, 2024 05:23
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* clean test images before test

Signed-off-by: chensuyue <[email protected]>

* add --no-cache for image build

Signed-off-by: chensuyue <[email protected]>

---------

Signed-off-by: chensuyue <[email protected]>
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
* clean test images before test

Signed-off-by: chensuyue <[email protected]>

* add --no-cache for image build

Signed-off-by: chensuyue <[email protected]>

---------

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: BaoHuiling <[email protected]>
tileintel pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 22, 2024
* clean test images before test

Signed-off-by: chensuyue <[email protected]>

* add --no-cache for image build

Signed-off-by: chensuyue <[email protected]>

---------

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
* clean test images before test

Signed-off-by: chensuyue <[email protected]>

* add --no-cache for image build

Signed-off-by: chensuyue <[email protected]>

---------

Signed-off-by: chensuyue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants