Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'vim' from all Dockerfiles #557

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Aug 23, 2024

Description

This is the first PR in a series of PRs to clean up OPEA containers

Issues

#265

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [Y] Bug fix (non-breaking change which fixes an issue)
  • [N] New feature (non-breaking change which adds new functionality)
  • [N] Breaking change (fix or feature that would break existing design and interface)
  • [Y] Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Everything needs to go through CI but I'm not expecting the changes to be breaking anything.

Signed-off-by: Abolfazl Shahbazi <[email protected]>
@ashahba ashahba added the r0.9 label Aug 23, 2024
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments.

comps/chathistory/mongo/docker/Dockerfile Outdated Show resolved Hide resolved
comps/llms/text-generation/native/docker/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Abolfazl Shahbazi <[email protected]>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chensuyue chensuyue removed the r0.9 label Aug 27, 2024
@chensuyue chensuyue added this to the v1.0 milestone Aug 27, 2024
@hshen14 hshen14 merged commit 25174c0 into opea-project:main Aug 27, 2024
44 checks passed
@ashahba ashahba deleted the ashahba/remove-vim branch August 28, 2024 00:23
@eero-t
Copy link
Contributor

eero-t commented Aug 28, 2024

@ashahba This seems to have missed few Dockerfiles from this repo (I guess they were merged while you worked on this PR):

$ find -name 'Dockerfile*' | xargs grep vim
./comps/embeddings/neural-speed/docker/Dockerfile:    vim
./comps/finetuning/docker/Dockerfile_hpu:RUN apt-get update -y && apt-get install -y vim htop net-tools dnsutils
./comps/finetuning/docker/Dockerfile_cpu:RUN apt-get update -y && apt-get install -y vim htop net-tools dnsutils

EDIT: dropped GenAIExamples comment, as I noticed that repo having been also updated just a moment ago.

sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
* Remove 'vim' from all Dockerfiles

Signed-off-by: Abolfazl Shahbazi <[email protected]>
lkk12014402 added a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants