Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChatQnA] Support K8S Python Client to export ChatQnA E2E manifests #634

Merged
merged 33 commits into from
Sep 11, 2024
Merged

[ChatQnA] Support K8S Python Client to export ChatQnA E2E manifests #634

merged 33 commits into from
Sep 11, 2024

Conversation

Zhenzhong1
Copy link
Collaborator

@Zhenzhong1 Zhenzhong1 commented Sep 6, 2024 •
edited
Loading

Description

Support K8S Python Client to export the all-in-one ChatQnA E2E manifest.

Usage:

python manifests_exporter.py

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

import kubernetes

Tests

CD

@kevinintel kevinintel added this to the v1.0 milestone Sep 6, 2024
@Zhenzhong1 Zhenzhong1 marked this pull request as ready for review September 6, 2024 08:35
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.06349% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/manifests_exporter.py 92.06% 10 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/manifests_exporter.py 92.06% <92.06%> (ø)

Zhenzhong1 and others added 12 commits September 10, 2024 02:56
@Zhenzhong1 Zhenzhong1 changed the title [ChatQnA] initialize the exporter for K8S manifests. [ChatQnA] Support K8S Python Client to export ChatQnA E2E manifests Sep 11, 2024
@kevinintel kevinintel mentioned this pull request Sep 11, 2024
Open
@Zhenzhong1
Copy link
Collaborator Author

ready for merge.
@kevinintel @lvliang-intel @chensuyue

@chensuyue
Copy link
Collaborator

Codecov Report

Attention: Patch coverage is 0% with 124 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/manifests_exporter.py 0.00% 124 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/manifests_exporter.py 0.00% <0.00%> (ø)

No UT coverage.

@Zhenzhong1
Copy link
Collaborator Author

UT added

@Zhenzhong1
Copy link
Collaborator Author

UT pass, ready for merge.
@chensuyue

@kevinintel kevinintel merged commit af4e0f8 into opea-project:main Sep 11, 2024
8 of 9 checks passed
@chensuyue
Copy link
Collaborator

Please check the https://results.pre-commit.ci/run/github/788916723/1726050752.pAJykM35Sq-Kic6aAzmWag CI issue.

@Zhenzhong1
Copy link
Collaborator Author

Please check the https://results.pre-commit.ci/run/github/788916723/1726050752.pAJykM35Sq-Kic6aAzmWag CI issue.

Fixed.#672

lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
@lvliang-intel
Clean deprecated VisualQnA code (#634)
87617e7 
* Clean deprecated VisualQnA code

Signed-off-by: lvliang-intel <[email protected]>

* update tgi repo

Signed-off-by: lvliang-intel <[email protected]>

---------

Signed-off-by: lvliang-intel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letonghan letonghan letonghan approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@lkk12014402 lkk12014402 lkk12014402 approved these changes

@chensuyue chensuyue Awaiting requested review from chensuyue

@kevinintel kevinintel Awaiting requested review from kevinintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Zhenzhong1 @chensuyue @lkk12014402 @lvliang-intel @letonghan @kevinintel