Refactor milvus dataprep and retriever #728
Conversation
bjzhjing
changed the title
bjzhjing
force-pushed
the
consolidate-milvus-dataprep-retriever
branch
from
558994d
to
d75c16b
Compare
bjzhjing
force-pushed
the
consolidate-milvus-dataprep-retriever
branch
from
f0e42b5
to
da89dfa
Compare
|
@XinyuYe-Intel Hi, could you please help review this PR? |
bjzhjing
force-pushed
the
consolidate-milvus-dataprep-retriever
branch
2 times, most recently
from
7022459
to
dd5081b
Compare
|
@chensuyue Hi Suyue, I checked the CI failure. For Microservice-test(dataprep_milvus_langchain, ...), the environment parameter is changed from MILVUS to MILVUS_HOST for dataprep_milvus_langchain, but this parameter seems to be hardcoded in CI, could you please update it? |
bjzhjing
force-pushed
the
consolidate-milvus-dataprep-retriever
branch
from
dd5081b
to
6f174d5
Compare
|
@XinyuYe-Intel please help merge this PR, thanks! |
please make sure to pass all tests. |
That is due to the hard code in CI script as I mentioned above. Could anyone from CI side take a look? @daisy-ycguo @chensuyue |
|
@bjzhjing, |
Milvus dataprep and retriever leverage the same embedding enpoints, but the embedding-related code is somewhat messed up, unify the namings and logic to improve code readability and facilitate user-friendly configuration. Signed-off-by: Cathy Zhang <[email protected]>
Signed-off-by: Cathy Zhang <[email protected]>
Signed-off-by: Cathy Zhang <[email protected]>
Signed-off-by: Cathy Zhang <[email protected]>
This is to fix the CI issue for MILVUS environment variable name is update. Signed-off-by: Cathy Zhang <[email protected]>
bjzhjing
force-pushed
the
consolidate-milvus-dataprep-retriever
branch
from
b98f908
to
b8d8d9a
Compare
for more information, see https://pre-commit.ci
@lvliang-intel @XinyuYe-Intel Hi, the test script is modified and CI has passed. |
Refactor the Milvus Dataprep and Retriever modules to enhance code readability and facilitate user-friendly configuration.