-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RetrievalTool Gateway to allow user setting retriever/reranker params #730
Update RetrievalTool Gateway to allow user setting retriever/reranker params #730
Conversation
…ranker params Signed-off-by: minmin-intel <[email protected]>
Signed-off-by: minmin-intel <[email protected]>
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: minmin-intel <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codes Looks good to me
My only concern is that it looks like this PR is not covered by any UT?
@chensuyue , is there any UT will cover gateway code change in GenAIComp? |
Looks like they pick ChatQnA example as UT. But I agree that the code changes in RetrievalToolGate was not tested in CICD. @chensuyue Can we add DocIndexRetriever example in the Example Test? |
Description
Previously user can only pass in query to the retrieval tool and there is no way to set retriever/reranker params with requests to the gateway. This PR is to expose these params to users and allow users to set retriever/reranker params with the requests to the gateway.
Issues
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
No newly introduced 3rd party dependency.
Tests
DocIndexRetriever example test