Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RetrievalTool Gateway to allow user setting retriever/reranker params #730

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

minmin-intel
Copy link
Collaborator

Description

Previously user can only pass in query to the retrieval tool and there is no way to set retriever/reranker params with requests to the gateway. This PR is to expose these params to users and allow users to set retriever/reranker params with the requests to the gateway.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

No newly introduced 3rd party dependency.

Tests

DocIndexRetriever example test

@minmin-intel minmin-intel requested review from xuechendi and XuhuiRen and removed request for lvliang-intel September 24, 2024 21:58
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/gateway.py 0.00% 12 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/gateway.py 34.71% <0.00%> (-0.61%) ⬇️

Copy link
Collaborator

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes Looks good to me
My only concern is that it looks like this PR is not covered by any UT?

@xuechendi
Copy link
Collaborator

@chensuyue , is there any UT will cover gateway code change in GenAIComp?

@minmin-intel
Copy link
Collaborator Author

Codes Looks good to me My only concern is that it looks like this PR is not covered by any UT?

Looks like they pick ChatQnA example as UT. But I agree that the code changes in RetrievalToolGate was not tested in CICD. @chensuyue Can we add DocIndexRetriever example in the Example Test?

@lvliang-intel lvliang-intel merged commit c7c45d6 into opea-project:main Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants