Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build #737

Merged
merged 11 commits into from
Sep 27, 2024
Merged

Fix image build #737

merged 11 commits into from
Sep 27, 2024

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Sep 25, 2024

Description

  1. fix image build issue
  2. fix test scripts path

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
pre-commit-ci bot and others added 6 commits September 25, 2024 08:28
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
@chensuyue
Copy link
Collaborator Author

Vectorstore/pathway: CI test failed #741 known issue.

Signed-off-by: chensuyue <[email protected]>
@berkecanrizai
Copy link
Contributor

berkecanrizai commented Sep 26, 2024

Hey @chensuyue , please see my reply here, this is due to the docker volume mount path in the test. You can either fix the path or mount the test file instead (if you feel like it has less chance to be moved in the future).

@chensuyue
Copy link
Collaborator Author

https://github.com/opea-project/GenAIComps/actions/runs/11065727650/job/30745644663?pr=737 seems caused by the invalid link in readme, please fix in another PR. @berkecanrizai

@chensuyue chensuyue merged commit c4f9083 into main Sep 27, 2024
14 of 15 checks passed
@chensuyue chensuyue deleted the suyue/fix_image branch September 27, 2024 07:37
chensuyue added a commit that referenced this pull request Oct 8, 2024
Signed-off-by: chensuyue <[email protected]>

(cherry picked from commit c4f9083)
Signed-off-by: chensuyue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants